PARQUET-360: Handle all map key types with cat tool's json dump #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nezihyigitbasi
force-pushed
the
parquet-cat-json
branch
from
50052ea to
e3c2669
Compare
Contributor
There was a problem hiding this comment.
I think this should use the BinaryNode that is used elsewhere to convert a Binary or byte[] to JSON. That will base64-encode the data so it is still binary rather than creating an array node.
nezihyigitbasi
force-pushed
the
parquet-cat-json
branch
from
6789d24 to
e4cd545
Compare
Contributor
Author
|
@rdblue updated, thanks. |
Contributor
|
Sorry, I should have mentioned this earlier: can you also add a test or two that exercises the new keyToString function? |
nezihyigitbasi
force-pushed
the
parquet-cat-json
branch
from
d92f70e to
995de88
Compare
Contributor
Author
|
@rdblue yeah totally forgot to add them. updated. |
Contributor
There was a problem hiding this comment.
Looks like you forgot to add a license header to this file and that's causing Travis CI to fail.
nezihyigitbasi
force-pushed
the
parquet-cat-json
branch
from
995de88 to
d047502
Compare
Contributor
|
Just tried to merge, but the format is wrong. Could you remove the square brackets from this PR title? Thanks! |
nezihyigitbasi
changed the title
Contributor
Author
|
@rdblue updated the title. |
Member
|
looks good to me. |
rdblue
pushed a commit
to rdblue/parquet-mr
that referenced
this pull request
Jul 13, 2016
When dumping a parquet map with `parquet-cat --json` it throws a class cast exception as it doesn't properly handle all map key types. ``` java.lang.ClassCastException: [B cannot be cast to java.lang.String at org.apache.parquet.tools.read.SimpleMapRecord.toJsonObject(SimpleMapRecord.java:34) at org.apache.parquet.tools.read.SimpleRecord.toJsonValue(SimpleRecord.java:119) at org.apache.parquet.tools.read.SimpleRecord.toJsonObject(SimpleRecord.java:112) at org.apache.parquet.tools.read.SimpleRecord.prettyPrintJson(SimpleRecord.java:106) at org.apache.parquet.tools.command.CatCommand.execute(CatCommand.java:76) at org.apache.parquet.tools.Main.main(Main.java:222) [B cannot be cast to java.lang.String ``` Author: Nezih Yigitbasi <nyigitbasi@netflix.com> Closes apache#259 from nezihyigitbasi/parquet-cat-json and squashes the following commits: d047502 [Nezih Yigitbasi] Add unit test e4cd545 [Nezih Yigitbasi] Get rid of deprecated methods bdc8fdf [Nezih Yigitbasi] Handle all map key types with cat tool's json dump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dumping a parquet map with
parquet-cat --jsonit throws a class cast exception as it doesn't properly handle all map key types.