PARQUET-367: "parquet-cat -j" doesn't show all records. #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sircodesalotOfTheRound
force-pushed
the
fix-parquet-cat
branch
3 times, most recently
from
32290ae to
9ee7825
Compare
sircodesalotOfTheRound
force-pushed
the
fix-parquet-cat
branch
from
9ee7825 to
e9b3829
Compare
Member
There was a problem hiding this comment.
If we want to do this, we should put it on the side of the caller of execute(...).
Contributor
Author
There was a problem hiding this comment.
I'm not sure why I added this actually... might have been a remnant from debugging. Will remove in final patch.
Member
|
Thanks for the contribution! |
sircodesalotOfTheRound
force-pushed
the
fix-parquet-cat
branch
from
e9b3829 to
dc639be
Compare
Added JsonRecordFormatter which formats SimpleRecords into an structure that can be used with ObjectMapper to create a valid json structure. Unit test included.
sircodesalotOfTheRound
force-pushed
the
fix-parquet-cat
branch
from
dc639be to
67207ef
Compare
Contributor
|
@julienledem, did you want to commit this? |
piyushnarang
pushed a commit
to piyushnarang/parquet-mr
that referenced
this pull request
Jun 15, 2016
Added JsonRecordFormatter which formats SimpleRecords into an structure that can be used with ObjectMapper to create a valid json structure. Unit test included. Author: Reuben Kuhnert <reuben.kuhnert@cloudera.com> Closes apache#281 from sircodesalotOfTheRound/fix-parquet-cat and squashes the following commits: 67207ef [Reuben Kuhnert] PARQUET-367: "parquet-cat -j" doesn't show all records.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added JsonRecordFormatter which formats SimpleRecords into an structure that can be used with ObjectMapper to create a valid json structure. Unit test included.