PARQUET-353: Release compression resources. #295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
Member
|
@jaltekruse did you have comments on this one? |
Contributor
Author
|
I'll rebase this and merge once #250 is in with the ParquetProperties refactor to avoid blocking the larger change. |
Contributor
There was a problem hiding this comment.
should this be in a finally block to release in the case where an exception occurs?
This updates the use of CodecFactory in the output format and writer classes so that its lifecycle is tied to ParquetWriter and ParquetRecordWriter. When those classes are closed, the resources held by the CodecFactory associated with the instance are released.
rdblue
force-pushed
the
PARQUET-353-release-compressor-resources
branch
from
27efab0 to
a00f4b7
Compare
Contributor
Author
|
Okay, rebased on PARQUET-99 and ready for another look. Thanks @julienledem and @jaltekruse! |
Contributor
Author
|
@jaltekruse, can you take a quick look at this patch? I've addressed the problem you identified and I'd like to get it in. Thanks for your help! |
Contributor
|
+1 |
Contributor
Author
|
Thanks! |
piyushnarang
pushed a commit
to piyushnarang/parquet-mr
that referenced
this pull request
Jun 15, 2016
This updates the use of CodecFactory in the output format and writer classes so that its lifecycle is tied to ParquetWriter and ParquetRecordWriter. When those classes are closed, the resources held by the CodecFactory associated with the instance are released. This is an alternative to and closes apache#282. Author: Ryan Blue <blue@apache.org> Closes apache#295 from rdblue/PARQUET-353-release-compressor-resources and squashes the following commits: a00f4b7 [Ryan Blue] PARQUET-353: Release compression resources.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jul 13, 2016
This updates the use of CodecFactory in the output format and writer classes so that its lifecycle is tied to ParquetWriter and ParquetRecordWriter. When those classes are closed, the resources held by the CodecFactory associated with the instance are released. This is an alternative to and closes apache#282. Author: Ryan Blue <blue@apache.org> Closes apache#295 from rdblue/PARQUET-353-release-compressor-resources and squashes the following commits: a00f4b7 [Ryan Blue] PARQUET-353: Release compression resources. Conflicts: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetRecordWriter.java parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java Resolution: Minor changes due to an argument relocation in the ByteBuffer patch that wasn't backported
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
This updates the use of CodecFactory in the output format and writer classes so that its lifecycle is tied to ParquetWriter and ParquetRecordWriter. When those classes are closed, the resources held by the CodecFactory associated with the instance are released. This is an alternative to and closes apache#282. Author: Ryan Blue <blue@apache.org> Closes apache#295 from rdblue/PARQUET-353-release-compressor-resources and squashes the following commits: a00f4b7 [Ryan Blue] PARQUET-353: Release compression resources. Conflicts: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetOutputFormat.java parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetRecordWriter.java parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java Resolution: Minor changes due to an argument relocation in the ByteBuffer patch that wasn't backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the use of CodecFactory in the output format and writer
classes so that its lifecycle is tied to ParquetWriter and
ParquetRecordWriter. When those classes are closed, the resources held
by the CodecFactory associated with the instance are released.
This is an alternative to and closes #282.