Closed
Conversation
rdblue
force-pushed
the
PARQUET-548-add-encoding-stats
branch
3 times, most recently
from
56c2486 to
c5f424f
Compare
rdblue
force-pushed
the
PARQUET-548-add-encoding-stats
branch
from
c5f424f to
e5c28a2
Compare
rdblue
force-pushed
the
PARQUET-548-add-encoding-stats
branch
from
e5c28a2 to
dc332d3
Compare
Contributor
Author
|
@danielcweeks and @julienledem, this would be a good one to get into 1.9.0 if we can. |
| import static org.apache.parquet.column.Encoding.PLAIN_DICTIONARY; | ||
| import static org.apache.parquet.column.Encoding.RLE_DICTIONARY; | ||
|
|
||
| public class EncodingStats { |
Member
There was a problem hiding this comment.
please add a short description in javadoc
Member
|
+1 LGTM |
piyushnarang
pushed a commit
to piyushnarang/parquet-mr
that referenced
this pull request
Jun 15, 2016
This adds `EncodingStats`, which tracks the number of pages for each encoding, separated into dictionary and data pages. It also adds convenience functions that are useful for dictionary filtering, like `hasDictionaryEncodedPages` and `hasNonDictionaryEncodedPages`. `EncodingStats` have a unit test in parquet-column and an integration test in parquet-hadoop that writes a file and verifies the stats are present and correct when it is read. This includes commits from apache#330 because it updates the dictionary filter. I'll rebase and remove them once it is merged. Author: Ryan Blue <blue@apache.org> Closes apache#332 from rdblue/PARQUET-548-add-encoding-stats and squashes the following commits: 5f148e6 [Ryan Blue] PARQUET-548: Fixes for review comments. dc332d3 [Ryan Blue] PARQUET-548: Add EncodingStats.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jul 13, 2016
This adds `EncodingStats`, which tracks the number of pages for each encoding, separated into dictionary and data pages. It also adds convenience functions that are useful for dictionary filtering, like `hasDictionaryEncodedPages` and `hasNonDictionaryEncodedPages`. `EncodingStats` have a unit test in parquet-column and an integration test in parquet-hadoop that writes a file and verifies the stats are present and correct when it is read. This includes commits from apache#330 because it updates the dictionary filter. I'll rebase and remove them once it is merged. Author: Ryan Blue <blue@apache.org> Closes apache#332 from rdblue/PARQUET-548-add-encoding-stats and squashes the following commits: 5f148e6 [Ryan Blue] PARQUET-548: Fixes for review comments. dc332d3 [Ryan Blue] PARQUET-548: Add EncodingStats. Conflicts: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java Resolution: Minor formatting changes conflicted with wrapping encodings in a HashSet.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 6, 2017
This adds `EncodingStats`, which tracks the number of pages for each encoding, separated into dictionary and data pages. It also adds convenience functions that are useful for dictionary filtering, like `hasDictionaryEncodedPages` and `hasNonDictionaryEncodedPages`. `EncodingStats` have a unit test in parquet-column and an integration test in parquet-hadoop that writes a file and verifies the stats are present and correct when it is read. This includes commits from apache#330 because it updates the dictionary filter. I'll rebase and remove them once it is merged. Author: Ryan Blue <blue@apache.org> Closes apache#332 from rdblue/PARQUET-548-add-encoding-stats and squashes the following commits: 5f148e6 [Ryan Blue] PARQUET-548: Fixes for review comments. dc332d3 [Ryan Blue] PARQUET-548: Add EncodingStats. Conflicts: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java Resolution: Minor formatting changes conflicted with wrapping encodings in a HashSet.
rdblue
added a commit
to rdblue/parquet-mr
that referenced
this pull request
Jan 10, 2017
This adds `EncodingStats`, which tracks the number of pages for each encoding, separated into dictionary and data pages. It also adds convenience functions that are useful for dictionary filtering, like `hasDictionaryEncodedPages` and `hasNonDictionaryEncodedPages`. `EncodingStats` have a unit test in parquet-column and an integration test in parquet-hadoop that writes a file and verifies the stats are present and correct when it is read. This includes commits from apache#330 because it updates the dictionary filter. I'll rebase and remove them once it is merged. Author: Ryan Blue <blue@apache.org> Closes apache#332 from rdblue/PARQUET-548-add-encoding-stats and squashes the following commits: 5f148e6 [Ryan Blue] PARQUET-548: Fixes for review comments. dc332d3 [Ryan Blue] PARQUET-548: Add EncodingStats. Conflicts: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageWriteStore.java Resolution: Minor formatting changes conflicted with wrapping encodings in a HashSet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
EncodingStats, which tracks the number of pages for each encoding, separated into dictionary and data pages. It also adds convenience functions that are useful for dictionary filtering, likehasDictionaryEncodedPagesandhasNonDictionaryEncodedPages.EncodingStatshave a unit test in parquet-column and an integration test in parquet-hadoop that writes a file and verifies the stats are present and correct when it is read.This includes commits from #330 because it updates the dictionary filter. I'll rebase and remove them once it is merged.