PARQUET-668 - Provide option to disable auto crop feature in dump #358
Conversation
parquet-tools/README.md
Outdated
| once | ||
| -d,--disable-data Do not dump column data | ||
| --debug Disable color output even if supported | ||
| --debug Enable debug output |
There was a problem hiding this comment.
thanks for fixing. I see the same error above. (line 85, 92)
either add -n in those paragraphs as well or rework a little to avoid repetition.
(common options paragraph or something)
There was a problem hiding this comment.
This text in the README is just the output of running java -jar parquet-tools.jar -h, and that help string is generated in Main.java (it merges the common option flags like --debug into every other command, see https://github.com/apache/parquet-mr/blob/master/parquet-tools/src/main/java/org/apache/parquet/tools/Main.java#L94) - so this help text is auto generated
I've updated the others items in the README with the correct output.
There was a problem hiding this comment.
Although do we even need the whole help string in the README? This issue could happen again if the options change.
Might be better to just direct the user to run -h to get usage details
There was a problem hiding this comment.
good point. Yes, showing the command line to get help would be better.
|
just one comment regarding README. otherwise. LGTM |
|
Updated README as discussed, only the |
|
LGTM |
2 participants
https://issues.apache.org/jira/browse/PARQUET-668
--disable-cropREADME.mdto reflect changes