Skip to content

Conversation

@gszadovszky
Copy link
Contributor

2 minor code/config modification related to the version upgrades:

  • TestMemoryManager.java: I guess, it was caused by the junit upgrade however, it is not clear why it was working before. The issue was that the second run of createWriter(1).close(null) failed with IOException about that the file already exists.
  • pom.xml (added exclusion for fastutil): The shaded dependency upgrade in parquet-column caused failure of API version compatibility check.

mvn clean install worked fine. Any idea about additional testing is welcomed.

@julienledem
Copy link
Member

LGTM. @rdblue ?

@rdblue
Copy link
Contributor

rdblue commented Jan 11, 2017

+1

It would be nice to move some of the versions embedded in submodules to properties, but I don't think that needs to block this commit.

@asfgit asfgit closed this in 6fb6085 Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants