Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Jan 20, 2021

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@wangyum
Copy link
Member Author

wangyum commented Jan 21, 2021

@wangyum
Copy link
Member Author

wangyum commented Jan 25, 2021

@bbraams I read a outdate document: http://mail-archives.apache.org/mod_mbox/parquet-dev/201906.mbox/%3CJIRA.13233926.1558083819000.446944.1560276180713@Atlassian.JIRA%3E

Both read and write are false:

   ### Documentation
   The feature is feature flagged and is disabled by default. Both writing out checksums and
verifying them on the read path can be turned on individually, via the following two new config
flags:
   * `parquet.page.write-checksum.enabled` (default: false)
   * `parquet.page.verify-checksum.enabled` (default: false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant