Remove spotbugs-annotations (#2320)

we dont seem to be running spotbugs/findbugs in our build, so depending
on the annotations is not necessary.

also fix name of common-codec lib.

Author: XN137

gradle/libs.versions.toml

@@ -44,7 +44,7 @@ awssdk-bom = { module = "software.amazon.awssdk:bom", version = "2.32.19" }
 awaitility = { module = "org.awaitility:awaitility", version = "4.3.0" }
 azuresdk-bom = { module = "com.azure:azure-sdk-bom", version = "1.2.37" }
 caffeine = { module = "com.github.ben-manes.caffeine:caffeine", version = "3.2.2" }
-commons-codec1 = { module = "commons-codec:commons-codec", version = "1.19.0" }
+commons-codec = { module = "commons-codec:commons-codec", version = "1.19.0" }
 commons-lang3 = { module = "org.apache.commons:commons-lang3", version = "3.18.0" }
 commons-text = { module = "org.apache.commons:commons-text", version = "1.14.0" }
 eclipselink = { module = "org.eclipse.persistence:eclipselink", version = "4.0.7" }
@@ -91,7 +91,6 @@ slf4j-api = { module = "org.slf4j:slf4j-api", version.ref = "slf4j" }
 smallrye-common-annotation = { module = "io.smallrye.common:smallrye-common-annotation", version = "2.13.8" }
 smallrye-config-core = { module = "io.smallrye.config:smallrye-config-core", version = "3.13.4" }
 spark35-sql-scala212 = { module = "org.apache.spark:spark-sql_2.12", version.ref = "spark35" }
-spotbugs-annotations = { module = "com.github.spotbugs:spotbugs-annotations", version = "4.9.4" }
 swagger-annotations = { module = "io.swagger:swagger-annotations", version.ref = "swagger" }
 swagger-jaxrs = { module = "io.swagger:swagger-jaxrs", version.ref = "swagger" }
 testcontainers-bom = { module = "org.testcontainers:testcontainers-bom", version = "1.21.3" }
@@ -102,4 +101,4 @@ jandex = { id = "org.kordamp.gradle.jandex", version = "2.2.0" }
 openapi-generator = { id = "org.openapi.generator", version = "7.12.0" }
 quarkus = { id = "io.quarkus", version.ref = "quarkus" }
 rat = { id = "org.nosphere.apache.rat", version = "0.8.1" }
-jetbrains-changelog = { id = "org.jetbrains.changelog",  version = "2.4.0"}
+jetbrains-changelog = { id = "org.jetbrains.changelog",  version = "2.4.0"}

polaris-core/build.gradle.kts

@@ -43,10 +43,9 @@ dependencies {
 
   implementation(libs.caffeine)
   implementation(libs.commons.lang3)
-  implementation(libs.commons.codec1)
+  implementation(libs.commons.codec)
   implementation(libs.guava)
   implementation(libs.slf4j.api)
-  compileOnly(libs.spotbugs.annotations)
 
   compileOnly(project(":polaris-immutables"))
   annotationProcessor(project(":polaris-immutables", configuration = "processor"))

polaris-core/src/main/java/org/apache/polaris/core/persistence/transactional/TransactionalMetaStoreManagerImpl.java

@@ -18,7 +18,6 @@
  */
 package org.apache.polaris.core.persistence.transactional;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.annotation.Nonnull;
 import jakarta.annotation.Nullable;
 import java.time.Clock;
@@ -86,7 +85,6 @@
  * Default implementation of the Polaris Meta Store Manager. Uses the underlying meta store to store
  * and retrieve all Polaris metadata
  */
-@SuppressFBWarnings("NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE")
 public class TransactionalMetaStoreManagerImpl extends BaseMetaStoreManager {
   private static final Logger LOGGER =
       LoggerFactory.getLogger(TransactionalMetaStoreManagerImpl.class);

runtime/service/build.gradle.kts

@@ -93,7 +93,6 @@ dependencies {
   implementation(libs.microprofile.fault.tolerance.api)
 
   compileOnly(libs.jakarta.annotation.api)
-  compileOnly(libs.spotbugs.annotations)
 
   implementation(platform(libs.google.cloud.storage.bom))
   implementation("com.google.cloud:google-cloud-storage")