Don't re-use STS Client Builder across threads (#82)

* don't re-use builder across threads

* style

Author: eric-maynard

polaris-service/src/main/java/io/polaris/service/PolarisApplication.java

@@ -144,13 +144,17 @@ public void run(PolarisApplicationConfig configuration, Environment environment)
     // PolarisEntityManager will be used for Management APIs and optionally the core Catalog APIs
     // depending on the value of the baseCatalogType config.
     MetaStoreManagerFactory metaStoreManagerFactory = configuration.getMetaStoreManagerFactory();
-    StsClientBuilder stsClientBuilder = StsClient.builder();
-    AwsCredentialsProvider awsCredentialsProvider = configuration.credentialsProvider();
-    if (awsCredentialsProvider != null) {
-      stsClientBuilder.credentialsProvider(awsCredentialsProvider);
-    }
+
     metaStoreManagerFactory.setStorageIntegrationProvider(
-        new PolarisStorageIntegrationProviderImpl(stsClientBuilder::build));
+        new PolarisStorageIntegrationProviderImpl(
+            () -> {
+              StsClientBuilder stsClientBuilder = StsClient.builder();
+              AwsCredentialsProvider awsCredentialsProvider = configuration.credentialsProvider();
+              if (awsCredentialsProvider != null) {
+                stsClientBuilder.credentialsProvider(awsCredentialsProvider);
+              }
+              return stsClientBuilder.build();
+            }));
 
     PolarisMetricRegistry polarisMetricRegistry =
         new PolarisMetricRegistry(new PrometheusMeterRegistry(PrometheusConfig.DEFAULT));