review comments from @flyrain

Author: adnanhemani

runtime/service/src/main/java/org/apache/polaris/service/config/FilterPriorities.java

@@ -22,7 +22,7 @@
 
 public final class FilterPriorities {
   public static final int REQUEST_ID_FILTER = Priorities.AUTHENTICATION - 101;
-  public static final int REALM_CONTEXT_FILTER = Priorities.AUTHENTICATION - 100;
+  public static final int REALM_CONTEXT_FILTER = REQUEST_ID_FILTER + 1;
   public static final int RATE_LIMITER_FILTER = Priorities.USER;
   public static final int MDC_FILTER = REALM_CONTEXT_FILTER + 1;
   public static final int TRACING_FILTER = REALM_CONTEXT_FILTER + 2;

runtime/service/src/main/java/org/apache/polaris/service/tracing/RequestIdGenerator.java

@@ -36,14 +36,12 @@ public class RequestIdGenerator {
   public String generateRequestId() {
     long currentCounter = COUNTER.incrementAndGet();
     String requestId = baseDefaultUuid + "_" + currentCounter;
-    if (currentCounter >= COUNTER_SOFT_MAX) {
-      if (resetInProgress.compareAndSet(false, true)) {
-        // If we get anywhere close to danger of overflowing Long (which, theoretically,
-        // would be extremely unlikely) rotate the UUID and start again.
-        baseDefaultUuid = UUID.randomUUID().toString();
-        COUNTER.set(0);
-        resetInProgress.set(false);
-      }
+    if (currentCounter >= COUNTER_SOFT_MAX && resetInProgress.compareAndSet(false, true)) {
+      // If we get anywhere close to danger of overflowing Long (which, theoretically,
+      // would be extremely unlikely) rotate the UUID and start again.
+      baseDefaultUuid = UUID.randomUUID().toString();
+      COUNTER.set(0);
+      resetInProgress.set(false);
     }
     return requestId;
   }