Remove @StaticInitSafe annotation (#1331)

There was an issue around mapped configurations having the `@StaticInitSafe` annotation that led to _two_ instances (a "static" one and a "somewhet application-scoped" one) - this was fixed in Quarkus 3.21. One bug in smallrye-config is fixed for Quarkus > 3.21.0, another issue however remains.

Since `@StaticInitSafe` annotated configs seem to cause some weird issues, it seems legit to remote that annotation altogether. This approach was [taken in Nessie](projectnessie/nessie#10606) as well. Investigations (via practical experiments) have proven that there's no measurable impact (runtime + heap) when doing this - and that's also been confirmed by Quarkus + Smallrye-config maintainers.

Hence this change remotes that annotation from the code base.

Author: snazy

extension/persistence/eclipselink/build.gradle.kts

@@ -34,9 +34,6 @@ dependencies {
 
   implementation(libs.eclipselink)
 
-  implementation(platform(libs.quarkus.bom))
-  implementation("io.quarkus:quarkus-core")
-
   implementation(libs.slf4j.api)
 
   val eclipseLinkDeps: String? = project.findProperty("eclipseLinkDeps") as String?
@@ -58,8 +55,8 @@ dependencies {
   compileOnly(libs.jakarta.annotation.api)
   compileOnly(libs.jakarta.enterprise.cdi.api)
   compileOnly(libs.jakarta.inject.api)
-  compileOnly("io.smallrye.common:smallrye-common-annotation") // @Identifier
-  compileOnly("io.smallrye.config:smallrye-config-core") // @ConfigMapping
+  compileOnly(libs.smallrye.common.annotation) // @Identifier
+  compileOnly(libs.smallrye.config.core) // @ConfigMapping
 
   compileOnly(platform(libs.jackson.bom))
   compileOnly("com.fasterxml.jackson.core:jackson-annotations")

extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/EclipseLinkConfiguration.java

@@ -18,13 +18,11 @@
  */
 package org.apache.polaris.extension.persistence.impl.eclipselink;
 
-import io.quarkus.runtime.annotations.StaticInitSafe;
 import io.smallrye.config.ConfigMapping;
 import io.smallrye.config.WithDefault;
 import java.nio.file.Path;
 import java.util.Optional;
 
-@StaticInitSafe
 @ConfigMapping(prefix = "polaris.persistence.eclipselink")
 public interface EclipseLinkConfiguration {
 

quarkus/service/src/main/java/org/apache/polaris/service/quarkus/auth/QuarkusAuthenticationConfiguration.java

@@ -18,11 +18,9 @@
  */
 package org.apache.polaris.service.quarkus.auth;
 
-import io.quarkus.runtime.annotations.StaticInitSafe;
 import io.smallrye.config.ConfigMapping;
 import org.apache.polaris.service.auth.AuthenticationConfiguration;
 
-@StaticInitSafe
 @ConfigMapping(prefix = "polaris.authentication")
 public interface QuarkusAuthenticationConfiguration extends AuthenticationConfiguration {
 

quarkus/service/src/main/java/org/apache/polaris/service/quarkus/catalog/io/QuarkusFileIOConfiguration.java

@@ -18,10 +18,8 @@
  */
 package org.apache.polaris.service.quarkus.catalog.io;
 
-import io.quarkus.runtime.annotations.StaticInitSafe;
 import io.smallrye.config.ConfigMapping;
 
-@StaticInitSafe
 @ConfigMapping(prefix = "polaris.file-io")
 public interface QuarkusFileIOConfiguration {
 

quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusBehaviorChangesConfiguration.java

@@ -21,15 +21,13 @@
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
-import io.quarkus.runtime.annotations.StaticInitSafe;
 import io.smallrye.config.ConfigMapping;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 import org.apache.polaris.service.config.FeaturesConfiguration;
 
-@StaticInitSafe
 @ConfigMapping(prefix = "polaris.behavior-changes")
 // FIXME: this should extend FeatureConfiguration, but that causes conflicts with
 // QuarkusFeaturesConfiguration

quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusFeaturesConfiguration.java

@@ -18,12 +18,10 @@
  */
 package org.apache.polaris.service.quarkus.config;
 
-import io.quarkus.runtime.annotations.StaticInitSafe;
 import io.smallrye.config.ConfigMapping;
 import java.util.Map;
 import org.apache.polaris.service.config.FeaturesConfiguration;
 
-@StaticInitSafe
 @ConfigMapping(prefix = "polaris.features")
 public interface QuarkusFeaturesConfiguration extends FeaturesConfiguration {
 

quarkus/service/src/main/java/org/apache/polaris/service/quarkus/context/QuarkusRealmContextConfiguration.java

@@ -18,11 +18,9 @@
  */
 package org.apache.polaris.service.quarkus.context;
 
-import io.quarkus.runtime.annotations.StaticInitSafe;
 import io.smallrye.config.ConfigMapping;
 import org.apache.polaris.service.context.RealmContextConfiguration;
 
-@StaticInitSafe
 @ConfigMapping(prefix = "polaris.realm-context")
 public interface QuarkusRealmContextConfiguration extends RealmContextConfiguration {
 

quarkus/service/src/main/java/org/apache/polaris/service/quarkus/logging/QuarkusLoggingConfiguration.java

@@ -18,11 +18,9 @@
  */
 package org.apache.polaris.service.quarkus.logging;
 
-import io.quarkus.runtime.annotations.StaticInitSafe;
 import io.smallrye.config.ConfigMapping;
 import java.util.Map;
 
-@StaticInitSafe
 @ConfigMapping(prefix = "polaris.log")
 public interface QuarkusLoggingConfiguration {
 

quarkus/service/src/main/java/org/apache/polaris/service/quarkus/metrics/QuarkusMetricsConfiguration.java

@@ -18,11 +18,9 @@
  */
 package org.apache.polaris.service.quarkus.metrics;
 
-import io.quarkus.runtime.annotations.StaticInitSafe;
 import io.smallrye.config.ConfigMapping;
 import java.util.Map;
 
-@StaticInitSafe
 @ConfigMapping(prefix = "polaris.metrics")
 public interface QuarkusMetricsConfiguration {
 

quarkus/service/src/main/java/org/apache/polaris/service/quarkus/persistence/QuarkusPersistenceConfiguration.java

@@ -18,10 +18,8 @@
  */
 package org.apache.polaris.service.quarkus.persistence;
 
-import io.quarkus.runtime.annotations.StaticInitSafe;
 import io.smallrye.config.ConfigMapping;
 
-@StaticInitSafe
 @ConfigMapping(prefix = "polaris.persistence")
 public interface QuarkusPersistenceConfiguration {