Rename NONE -> IMPLICIT

Author: poojanilangekar

polaris-core/src/main/java/org/apache/polaris/core/connection/AuthenticationParametersDpo.java

@@ -39,7 +39,7 @@
 @JsonSubTypes({
   @JsonSubTypes.Type(value = OAuthClientCredentialsParametersDpo.class, name = "1"),
   @JsonSubTypes.Type(value = BearerAuthenticationParametersDpo.class, name = "2"),
-  @JsonSubTypes.Type(value = NoneAuthenticationParametersDpo.class, name = "3"),
+  @JsonSubTypes.Type(value = ImplicitAuthenticationParametersDpo.class, name = "3"),
 })
 public abstract class AuthenticationParametersDpo implements IcebergCatalogPropertiesProvider {
 
@@ -82,8 +82,8 @@ public static AuthenticationParametersDpo fromAuthenticationParametersModelWithS
             new BearerAuthenticationParametersDpo(
                 secretReferences.get(INLINE_BEARER_TOKEN_REFERENCE_KEY));
         break;
-      case NONE:
-        config = new NoneAuthenticationParametersDpo();
+      case IMPLICIT:
+        config = new ImplicitAuthenticationParametersDpo();
         break;
       default:
         throw new IllegalStateException(

polaris-core/src/main/java/org/apache/polaris/core/connection/AuthenticationType.java

@@ -33,7 +33,7 @@ public enum AuthenticationType {
   NULL_TYPE(0),
   OAUTH(1),
   BEARER(2),
-  NONE(3),
+  IMPLICIT(3),
   ;
 
   private static final AuthenticationType[] REVERSE_MAPPING_ARRAY;

polaris-core/src/main/java/org/apache/polaris/core/connection/NoneAuthenticationParametersDpo.java renamed to polaris-core/src/main/java/org/apache/polaris/core/connection/ImplicitAuthenticationParametersDpo.java

@@ -21,17 +21,17 @@
 import com.google.common.base.MoreObjects;
 import java.util.Map;
 import org.apache.polaris.core.admin.model.AuthenticationParameters;
-import org.apache.polaris.core.admin.model.NoneAuthenticationParameters;
+import org.apache.polaris.core.admin.model.ImplicitAuthenticationParameters;
 import org.apache.polaris.core.secrets.UserSecretsManager;
 
 /**
- * The internal persistence-object counterpart to NoneAuthenticationParameters defined in the API
- * model.
+ * The internal persistence-object counterpart to ImplicitAuthenticationParameters defined in the
+ * API model.
  */
-public class NoneAuthenticationParametersDpo extends AuthenticationParametersDpo {
+public class ImplicitAuthenticationParametersDpo extends AuthenticationParametersDpo {
 
-  public NoneAuthenticationParametersDpo() {
-    super(AuthenticationType.NONE.getCode());
+  public ImplicitAuthenticationParametersDpo() {
+    super(AuthenticationType.IMPLICIT.getCode());
   }
 
   @Override
@@ -41,8 +41,8 @@ public Map<String, String> asIcebergCatalogProperties(UserSecretsManager secrets
 
   @Override
   public AuthenticationParameters asAuthenticationParametersModel() {
-    return NoneAuthenticationParameters.builder()
-        .setAuthenticationType(AuthenticationParameters.AuthenticationTypeEnum.NONE)
+    return ImplicitAuthenticationParameters.builder()
+        .setAuthenticationType(AuthenticationParameters.AuthenticationTypeEnum.IMPLICIT)
         .build();
   }
 

polaris-core/src/test/java/org/apache/polaris/core/connection/ConnectionConfigInfoDpoTest.java

@@ -133,7 +133,7 @@ void testBearerAuthenticationParameters() throws JsonProcessingException {
   }
 
   @Test
-  void testNoneAuthenticationParameters() throws JsonProcessingException {
+  void testImplicitAuthenticationParameters() throws JsonProcessingException {
     // Test deserialization and reserialization of the persistence JSON.
     String json =
         ""
@@ -162,7 +162,7 @@ void testNoneAuthenticationParameters() throws JsonProcessingException {
             + "  \"uri\": \"file:///hadoop-catalog/warehouse\","
             + "  \"warehouse\": \"hadoop-catalog\","
             + "  \"authenticationParameters\": {"
-            + "    \"authenticationType\": \"NONE\""
+            + "    \"authenticationType\": \"IMPLICIT\""
             + "  }"
             + "}";
     Assertions.assertEquals(

service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java

@@ -704,7 +704,7 @@ private Map<String, UserSecretReference> extractSecretReferences(
   private boolean requiresSecretReferenceExtraction(
       @NotNull ConnectionConfigInfo connectionConfigInfo) {
     return connectionConfigInfo.getAuthenticationParameters().getAuthenticationType()
-        != AuthenticationParameters.AuthenticationTypeEnum.NONE;
+        != AuthenticationParameters.AuthenticationTypeEnum.IMPLICIT;
   }
 
   public PolarisEntity createCatalog(CreateCatalogRequest catalogRequest) {
@@ -768,8 +768,8 @@ public PolarisEntity createCatalog(CreateCatalogRequest catalogRequest) {
           // Support no-auth catalog federation only when the feature is enabled.
           checkState(
               supportedAuthenticationTypes.contains(
-                  AuthenticationParameters.AuthenticationTypeEnum.NONE.name()),
-              "Authentication-less catalog federation is not supported.");
+                  AuthenticationParameters.AuthenticationTypeEnum.IMPLICIT.name()),
+              "Implicit authentication based catalog federation is not supported.");
         }
         entity =
             new CatalogEntity.Builder(entity)

spec/polaris-management-service.yml

@@ -917,7 +917,7 @@ components:
             - OAUTH
             - BEARER
             - SIGV4
-            - NONE
+            - IMPLICIT
           description: The type of authentication to use when connecting to the remote rest service
       required:
         - authenticationType
@@ -927,7 +927,7 @@ components:
           OAUTH: "#/components/schemas/OAuthClientCredentialsParameters"
           BEARER: "#/components/schemas/BearerAuthenticationParameters"
           SIGV4: "#/components/schemas/SigV4AuthenticationParameters"
-          NONE: "#/components/schemas/NoneAuthenticationParameters"
+          IMPLICIT: "#/components/schemas/ImplicitAuthenticationParameters"
 
     OAuthClientCredentialsParameters:
       type: object
@@ -992,9 +992,10 @@ components:
         - roleArn
         - signingRegion
 
-    NoneAuthenticationParameters:
+    ImplicitAuthenticationParameters:
       type: object
-      description: No authentication required for the connection
+      description: Polaris does not explicity accept any authentication parameters for the connection. Authentication 
+        parameters found in the environment and/or configuration files will be used for this connection.
       allOf:
         - $ref: '#/components/schemas/AuthenticationParameters'