Address Minor PR Comments

Author: adam-christian-software

persistence/nosql/idgen/api/src/main/java/org/apache/polaris/ids/api/IdGenerator.java

@@ -18,11 +18,12 @@
  */
 package org.apache.polaris.ids.api;
 
+/** The primary interface for generating a contention-free ID. */
 public interface IdGenerator {
   /** Generate a new, unique ID. */
   long generateId();
 
-  /** Generate the system ID for a node, solely used by/for node management purposes. */
+  /** Generate the system ID for a node, solely used for node management. */
   long systemIdForNode(int nodeId);
 
   default String describeId(long id) {
@@ -33,12 +34,12 @@ default String describeId(long id) {
       new IdGenerator() {
         @Override
         public long generateId() {
-          throw new UnsupportedOperationException("NONE IdGenerator");
+          throw new UnsupportedOperationException("NONE IdGenerator cannot generate IDs.");
         }
 
         @Override
         public long systemIdForNode(int nodeId) {
-          throw new UnsupportedOperationException("NONE IdGenerator");
+          throw new UnsupportedOperationException("NONE IdGenerator cannot generate IDs.");
         }
       };
 }

persistence/nosql/idgen/api/src/main/java/org/apache/polaris/ids/api/SnowflakeIdGenerator.java

@@ -25,8 +25,7 @@
 
 public interface SnowflakeIdGenerator extends IdGenerator {
   /** Offset of the snowflake ID generator since the 1970-01-01T00:00:00Z epoch instant. */
-  Instant EPOCH_OFFSET =
-      Instant.EPOCH.atZone(ZoneId.of("GMT")).withYear(2025).withMonth(3).toInstant();
+  Instant EPOCH_OFFSET = Instant.parse("2025-03-01T00:00:00Z");
 
   /**
    * Offset of the snowflake ID generator in milliseconds since the 1970-01-01T00:00:00Z epoch

persistence/nosql/idgen/impl/src/main/java/org/apache/polaris/ids/impl/SnowflakeIdGeneratorFactory.java

@@ -50,8 +50,7 @@ public void validateParameters(Map<String, String> params, IdGeneratorSource idG
   }
 
   @Override
-  public SnowflakeIdGenerator buildSystemIdGenerator(
-      Map<String, String> params, LongSupplier clockMillis) {
+  public SnowflakeIdGenerator buildSystemIdGenerator(Map<String, String> params) {
     return buildIdGenerator(
         params,
         new IdGeneratorSource() {

persistence/nosql/idgen/spi/src/main/java/org/apache/polaris/ids/spi/IdGeneratorFactory.java

@@ -23,14 +23,15 @@
 import java.util.function.LongSupplier;
 import org.apache.polaris.ids.api.IdGenerator;
 
+/** Provides values for ID generators, usually provided by {@code NodeLease} implementations. */
 public interface IdGeneratorFactory<I extends IdGenerator> {
   String name();
 
   void validateParameters(Map<String, String> params, IdGeneratorSource idGeneratorSource);
 
   I buildIdGenerator(Map<String, String> params, IdGeneratorSource idGeneratorSource);
 
-  I buildSystemIdGenerator(Map<String, String> params, LongSupplier clockMillis);
+  I buildSystemIdGenerator(Map<String, String> params);
 
   static IdGeneratorFactory<?> lookupFactory(String name) {
     for (IdGeneratorFactory<?> factory : ServiceLoader.load(IdGeneratorFactory.class)) {