Skip to content

Commit 65ac17a

Browse files
author
Yufei Gu
committed
Resolve comments
1 parent 2345c54 commit 65ac17a

File tree

2 files changed

+13
-44
lines changed

2 files changed

+13
-44
lines changed

polaris-core/src/test/java/org/apache/polaris/core/policy/PolicyTypeTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,13 @@
2020

2121
import java.util.stream.Stream;
2222
import org.assertj.core.api.Assertions;
23+
import org.junit.jupiter.api.Test;
2324
import org.junit.jupiter.params.ParameterizedTest;
2425
import org.junit.jupiter.params.provider.Arguments;
2526
import org.junit.jupiter.params.provider.MethodSource;
2627

28+
import static org.assertj.core.api.Assertions.assertThat;
29+
2730
public class PolicyTypeTest {
2831

2932
static Stream<Arguments> predefinedPolicyTypes() {
@@ -53,4 +56,14 @@ public void testPredefinedPolicyTypeFromName(int code, String name, boolean isIn
5356
Assertions.assertThat(policyType.getName()).isEqualTo(name);
5457
Assertions.assertThat(policyType.isInheritable()).isEqualTo(isInheritable);
5558
}
59+
60+
@Test
61+
void fromCodeReturnsNullForNegative() {
62+
assertThat(PolicyType.fromCode(-1)).isNull();
63+
}
64+
65+
@Test
66+
void fromNameReturnsNullForUnknown() {
67+
assertThat(PolicyType.fromName("__unknown__")).isNull();
68+
}
5669
}

polaris-core/src/test/java/org/apache/polaris/core/policy/PredefinedPolicyTypesTest.java

Lines changed: 0 additions & 44 deletions
This file was deleted.

0 commit comments

Comments
 (0)