Skip to content

Commit 6844069

Browse files
authored
Fix RDS devservices config + adopt for :polaris-admin:test (#2723)
Changes: * Disables devservices for `:polaris-admin` tests as well, which is necessary to _not_ spin up test containers. * Use the explicit devservices-config as everywhere else. The first bullet point can cause excessive memory usage, especially with more test classes, eventually killing the whole GH runner.
1 parent dedda29 commit 6844069

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

runtime/admin/src/main/resources/application.properties

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,11 @@ quarkus.container-image.group=apache
3232
quarkus.container-image.name=polaris-admin-tool
3333
quarkus.container-image.additional-tags=latest
3434
quarkus.datasource.db-kind=postgresql
35-
#https://docs.quarkiverse.io/quarkus-amazon-services/dev/amazon-rds.html#_configuring_rds_clients
35+
# if set to true it will try to start localstack at build and run time for the local environment
36+
# https://docs.quarkiverse.io/quarkus-amazon-services/dev/amazon-rds.html#_configuration_reference for more details
37+
quarkus.rds.devservices.enabled=false
3638
quarkus.rds.sync-client.type=apache
39+
3740
# ---- Runtime Configuration ----
3841
# Below are default values for properties that can be changed in runtime.
3942

runtime/defaults/src/main/resources/application.properties

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,14 +125,11 @@ polaris.persistence.type=in-memory
125125
# polaris.persistence.type=relational-jdbc
126126

127127
polaris.secrets-manager.type=in-memory
128-
# disable localstack
129128
# if set to true it will try to start localstack at build and run time for the local environment
130129
# https://docs.quarkiverse.io/quarkus-amazon-services/dev/amazon-rds.html#_configuration_reference for more details
131-
quarkus.devservices.enabled=false
130+
quarkus.rds.devservices.enabled=false
132131
quarkus.rds.sync-client.type=apache
133132

134-
135-
136133
polaris.file-io.type=default
137134

138135
polaris.event-listener.type=no-op

0 commit comments

Comments
 (0)