Skip to content

Commit 828730a

Browse files
committed
add comments
1 parent d285a0a commit 828730a

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

build-logic/src/main/kotlin/Utilities.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@
2020
import org.gradle.api.Project
2121
import org.gradle.process.JavaForkOptions
2222

23+
/**
24+
* Extract the scala version from polaris spark project, and points the build directory to a sub-dir
25+
* that uses scala version as name. The polaris spark project name is in format of
26+
* <project>-<sparkVersion>_<scalaVersion>, for example: polaris-spark-3.5_2.12.
27+
*/
2328
fun Project.getAndUseScalaVersionForProject(): String {
2429
val sparkScala = project.name.split("-").last().split("_")
2530

plugins/spark/v3.5/integration/src/intTest/java/org/apache/polaris/spark/quarkus/it/SparkCatalogOperationsIT.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,11 @@
3838

3939
@QuarkusIntegrationTest
4040
public class SparkCatalogOperationsIT extends SparkIntegrationBase {
41+
/**
42+
* This integration directly performs operations using the SparkCatalog instance, instead of going
43+
* through Spark SQL interface. Some operations don't have an easy way to trigger through the
44+
* SparkSQL, for example, list nested namespaces.
45+
*/
4146
private static StructType schema = new StructType().add("id", "long").add("name", "string");
4247

4348
@Test

plugins/spark/v3.5/integration/src/intTest/resources/META-INF/services/org.apache.polaris.service.it.ext.PolarisServerManager

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@
1717
# under the License.
1818
#
1919

20-
org.apache.polaris.service.quarkus.it.QuarkusServerManager
20+
org.apache.polaris.service.quarkus.it.QuarkusServerManager

0 commit comments

Comments
 (0)