move all functions to PolarisEndpoints

Author: gh-yzou

polaris-core/src/main/java/org/apache/polaris/core/rest/PolarisEndpoints.java

@@ -21,6 +21,8 @@
 import com.google.common.collect.ImmutableSet;
 import java.util.Set;
 import org.apache.iceberg.rest.Endpoint;
+import org.apache.polaris.core.config.FeatureConfiguration;
+import org.apache.polaris.core.context.CallContext;
 
 public class PolarisEndpoints {
   public static final Endpoint V1_LIST_GENERIC_TABLES =
@@ -39,4 +41,20 @@ public class PolarisEndpoints {
           .add(V1_DELETE_GENERIC_TABLE)
           .add(V1_LOAD_GENERIC_TABLE)
           .build();
+
+  /**
+   * Get the generic table endpoints. Returns GENERIC_TABLE_ENDPOINTS if ENABLE_GENERIC_TABLES is
+   * set to true, otherwise, returns an empty set.
+   */
+  public static Set<Endpoint> getSupportedGenericTableEndpoints(CallContext callContext) {
+    // add the generic table endpoints as supported endpoints if generic table feature is enabled.
+    boolean genericTableEnabled =
+        callContext
+            .getPolarisCallContext()
+            .getConfigurationStore()
+            .getConfiguration(
+                callContext.getPolarisCallContext(), FeatureConfiguration.ENABLE_GENERIC_TABLES);
+
+    return genericTableEnabled ? PolarisEndpoints.GENERIC_TABLE_ENDPOINTS : ImmutableSet.of();
+  }
 }

service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java

@@ -59,7 +59,6 @@
 import org.apache.iceberg.rest.responses.LoadTableResponse;
 import org.apache.polaris.core.auth.AuthenticatedPolarisPrincipal;
 import org.apache.polaris.core.auth.PolarisAuthorizer;
-import org.apache.polaris.core.config.FeatureConfiguration;
 import org.apache.polaris.core.context.CallContext;
 import org.apache.polaris.core.context.RealmContext;
 import org.apache.polaris.core.entity.PolarisEntity;
@@ -705,16 +704,6 @@ public Response getConfig(
 
     String prefix = prefixParser.catalogNameToPrefix(realmContext, warehouse);
 
-    // add the generic table endpoints as supported endpoints if generic table feature is enabled.
-    boolean genericTableEnabled =
-        callContext
-            .getPolarisCallContext()
-            .getConfigurationStore()
-            .getConfiguration(
-                callContext.getPolarisCallContext(), FeatureConfiguration.ENABLE_GENERIC_TABLES);
-    Set<Endpoint> supportedGenericTableEndpoints =
-        genericTableEnabled ? PolarisEndpoints.GENERIC_TABLE_ENDPOINTS : ImmutableSet.of();
-
     return Response.ok(
             ConfigResponse.builder()
                 .withDefaults(properties) // catalog properties are defaults
@@ -724,7 +713,7 @@ public Response getConfig(
                         .addAll(DEFAULT_ENDPOINTS)
                         .addAll(VIEW_ENDPOINTS)
                         .addAll(COMMIT_ENDPOINT)
-                        .addAll(supportedGenericTableEndpoints)
+                        .addAll(PolarisEndpoints.getSupportedGenericTableEndpoints(callContext))
                         .build())
                 .build())
         .build();