review: rename to PURGE_VIEW_METADATA_ON_DROP

Author: dimas-b

CHANGELOG.md

@@ -50,7 +50,7 @@ at locations that better optimize for object storage.
 - The Helm chart now supports Pod Disruption Budgets (PDBs) for Polaris components. This allows users to define
   the minimum number of pods that must be available during voluntary disruptions, such as node maintenance.
 
-- Feature configuration `PURGE_VIEWS_ON_DROP` was added to allow dropping views without purging their metadata files.
+- Feature configuration `PURGE_VIEW_METADATA_ON_DROP` was added to allow dropping views without purging their metadata files.
 
 ### Changes
 

integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogIntegrationBase.java

@@ -1213,13 +1213,13 @@ public void testDropViewWithPurge() {
     Catalog catalog = managementApi.getCatalog(currentCatalogName);
     Map<String, String> catalogProps = new HashMap<>(catalog.getProperties().toMap());
     catalogProps.put(FeatureConfiguration.DROP_WITH_PURGE_ENABLED.catalogConfig(), "false");
-    catalogProps.put(FeatureConfiguration.PURGE_VIEWS_ON_DROP.catalogConfig(), "true");
+    catalogProps.put(FeatureConfiguration.PURGE_VIEW_METADATA_ON_DROP.catalogConfig(), "true");
     managementApi.updateCatalog(catalog, catalogProps);
 
     assertThatThrownBy(() -> restCatalog.dropView(id)).isInstanceOf(ForbiddenException.class);
 
     catalog = managementApi.getCatalog(currentCatalogName);
-    catalogProps.put(FeatureConfiguration.PURGE_VIEWS_ON_DROP.catalogConfig(), "false");
+    catalogProps.put(FeatureConfiguration.PURGE_VIEW_METADATA_ON_DROP.catalogConfig(), "false");
     managementApi.updateCatalog(catalog, catalogProps);
 
     assertThatCode(() -> restCatalog.dropView(id)).doesNotThrowAnyException();

polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java

@@ -191,10 +191,10 @@ public static void enforceFeatureEnabledOrThrow(
           .defaultValue(false)
           .buildFeatureConfiguration();
 
-  public static final FeatureConfiguration<Boolean> PURGE_VIEWS_ON_DROP =
+  public static final FeatureConfiguration<Boolean> PURGE_VIEW_METADATA_ON_DROP =
       PolarisConfiguration.<Boolean>builder()
-          .key("PURGE_VIEWS_ON_DROP")
-          .catalogConfig("polaris.config.purge-views-on-drop")
+          .key("PURGE_VIEW_METADATA_ON_DROP")
+          .catalogConfig("polaris.config.purge-view-metadata-on-drop")
           .description(
               "Indicates whether Polaris should purge view metadata files when a view is dropped.")
           .defaultValue(true)

runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java

@@ -804,7 +804,7 @@ public boolean dropView(TableIdentifier identifier) {
     boolean purge =
         callContext
             .getRealmConfig()
-            .getConfig(FeatureConfiguration.PURGE_VIEWS_ON_DROP, catalogEntity);
+            .getConfig(FeatureConfiguration.PURGE_VIEW_METADATA_ON_DROP, catalogEntity);
 
     return dropTableLike(PolarisEntitySubType.ICEBERG_VIEW, identifier, Map.of(), purge)
         .isSuccess();