review

Author: adutra

polaris-core/src/main/java/io/polaris/core/catalog/PolarisCatalogHelpers.java

@@ -15,6 +15,7 @@
  */
 package io.polaris.core.catalog;
 
+import com.google.common.collect.ImmutableList;
 import io.polaris.core.entity.PolarisEntity;
 import java.util.ArrayList;
 import java.util.Arrays;
@@ -36,9 +37,11 @@ public class PolarisCatalogHelpers {
   private PolarisCatalogHelpers() {}
 
   public static List<String> tableIdentifierToList(TableIdentifier identifier) {
-    List<String> fullList = new ArrayList<>(Arrays.asList(identifier.namespace().levels()));
+    ImmutableList.Builder<String> fullList =
+        ImmutableList.builderWithExpectedSize(identifier.namespace().length() + 1);
+    fullList.addAll(Arrays.asList(identifier.namespace().levels()));
     fullList.add(identifier.name());
-    return fullList;
+    return fullList.build();
   }
 
   public static TableIdentifier listToTableIdentifier(List<String> ids) {

polaris-service/src/main/java/io/polaris/service/catalog/PolarisCatalogHandlerWrapper.java

@@ -731,10 +731,7 @@ public boolean sendNotification(TableIdentifier identifier, NotificationRequest
     for (int i = 1; i <= identifier.namespace().length(); i++) {
       Namespace nsLevel =
           Namespace.of(
-              Arrays.stream(identifier.namespace().levels())
-                  .limit(i)
-                  .toList()
-                  .toArray(String[]::new));
+              Arrays.stream(identifier.namespace().levels()).limit(i).toArray(String[]::new));
       extraPassthroughNamespaces.add(nsLevel);
     }
     authorizeBasicNamespaceOperationOrThrow(