Revisions based on review from @snazy

Author: adnanhemani

service/common/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java

@@ -409,7 +409,7 @@ public Response rotateCredentials(
     PolarisAdminService adminService = newAdminService(realmContext, securityContext);
     PrincipalWithCredentials rotatedPrincipal = adminService.rotateCredentials(principalName);
     polarisEventListener.onAfterCredentialsRotate(
-        new AfterCredentialsRotateEvent(rotatedPrincipal));
+        new AfterCredentialsRotateEvent(rotatedPrincipal.getPrincipal()));
     return Response.ok(rotatedPrincipal).build();
   }
 

service/common/src/main/java/org/apache/polaris/service/events/AfterCatalogGetEvent.java

@@ -21,5 +21,5 @@
 
 import org.apache.polaris.core.admin.model.Catalog;
 
-/** Emitted when Polaris intends to get a catalog. */
+/** Emitted when Polaris retrieves a catalog. */
 public record AfterCatalogGetEvent(Catalog catalog) implements PolarisEvent {}

service/common/src/main/java/org/apache/polaris/service/events/AfterCredentialsRotateEvent.java

@@ -19,12 +19,12 @@
 
 package org.apache.polaris.service.events;
 
-import org.apache.polaris.core.admin.model.PrincipalWithCredentials;
+import org.apache.polaris.core.admin.model.Principal;
 
 /**
  * Event fired after credentials are rotated for a principal in Polaris.
  *
  * @param rotatedPrincipal the updated principal with new credentials
  */
-public record AfterCredentialsRotateEvent(PrincipalWithCredentials rotatedPrincipal)
+public record AfterCredentialsRotateEvent(Principal rotatedPrincipal)
     implements PolarisEvent {}