Skip to content

Commit fbeb804

Browse files
update test partition stat write impl
1 parent ed52217 commit fbeb804

File tree

3 files changed

+18
-28
lines changed

3 files changed

+18
-28
lines changed

quarkus/service/src/test/java/org/apache/polaris/service/quarkus/task/BatchFileCleanupTaskHandlerTest.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,7 @@ public void close() {
128128
PartitionStatisticsFile partitionStatisticsFile1 =
129129
TaskTestUtils.writePartitionStatsFile(
130130
snapshot.snapshotId(),
131-
snapshot.sequenceNumber(),
132-
"/metadata/" + UUID.randomUUID() + ".stats",
131+
"/metadata/" + "partition-stats-" + UUID.randomUUID() + ".parquet",
133132
fileIO);
134133
String firstMetadataFile = "v1-295495059.metadata.json";
135134
TableMetadata firstMetadata =
@@ -162,8 +161,7 @@ public void close() {
162161
PartitionStatisticsFile partitionStatisticsFile2 =
163162
TaskTestUtils.writePartitionStatsFile(
164163
snapshot2.snapshotId(),
165-
snapshot2.sequenceNumber(),
166-
"/metadata/" + UUID.randomUUID() + ".stats",
164+
"/metadata/" + "partition-stats-" + UUID.randomUUID() + ".parquet",
167165
fileIO);
168166
String secondMetadataFile = "v1-295495060.metadata.json";
169167
TableMetadata secondMetadata =
@@ -182,8 +180,6 @@ public void close() {
182180
Stream.of(
183181
secondMetadata.previousFiles().stream().map(TableMetadata.MetadataLogEntry::file),
184182
secondMetadata.statisticsFiles().stream().map(StatisticsFile::path),
185-
firstMetadata.partitionStatisticsFiles().stream()
186-
.map(PartitionStatisticsFile::path),
187183
secondMetadata.partitionStatisticsFiles().stream()
188184
.map(PartitionStatisticsFile::path))
189185
.flatMap(s -> s)

quarkus/service/src/test/java/org/apache/polaris/service/quarkus/task/TableCleanupTaskHandlerTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -510,8 +510,7 @@ public void testTableCleanupMultipleMetadata() throws IOException {
510510
PartitionStatisticsFile partitionStatisticsFile1 =
511511
TaskTestUtils.writePartitionStatsFile(
512512
snapshot.snapshotId(),
513-
snapshot.sequenceNumber(),
514-
"/metadata/" + UUID.randomUUID() + ".stats",
513+
"/metadata/" + "partition-stats-" + UUID.randomUUID() + ".parquet",
515514
fileIO);
516515
String firstMetadataFile = "v1-295495059.metadata.json";
517516
TableMetadata firstMetadata =
@@ -544,8 +543,7 @@ public void testTableCleanupMultipleMetadata() throws IOException {
544543
PartitionStatisticsFile partitionStatisticsFile2 =
545544
TaskTestUtils.writePartitionStatsFile(
546545
snapshot2.snapshotId(),
547-
snapshot2.sequenceNumber(),
548-
"/metadata/" + UUID.randomUUID() + ".stats",
546+
"/metadata/" + "partition-stats-" + UUID.randomUUID() + ".parquet",
549547
fileIO);
550548
String secondMetadataFile = "v1-295495060.metadata.json";
551549
TaskTestUtils.writeTableMetadata(

quarkus/service/src/test/java/org/apache/polaris/service/quarkus/task/TaskTestUtils.java

Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
import jakarta.annotation.Nonnull;
2222
import java.io.IOException;
23+
import java.io.UncheckedIOException;
2324
import java.nio.ByteBuffer;
2425
import java.nio.charset.StandardCharsets;
2526
import java.util.Arrays;
@@ -181,24 +182,19 @@ public static StatisticsFile writeStatsFile(
181182
}
182183

183184
public static PartitionStatisticsFile writePartitionStatsFile(
184-
long snapshotId, long snapshotSequenceNumber, String statsLocation, FileIO fileIO)
185-
throws IOException {
186-
187-
try (PuffinWriter puffinWriter = Puffin.write(fileIO.newOutputFile(statsLocation)).build()) {
188-
puffinWriter.add(
189-
new Blob(
190-
"some-blob-type",
191-
List.of(1),
192-
snapshotId,
193-
snapshotSequenceNumber,
194-
ByteBuffer.wrap("blob content".getBytes(StandardCharsets.UTF_8))));
195-
puffinWriter.finish();
196-
197-
return ImmutableGenericPartitionStatisticsFile.builder()
198-
.snapshotId(snapshotId)
199-
.path(statsLocation)
200-
.fileSizeInBytes(puffinWriter.fileSize())
201-
.build();
185+
long snapshotId, String statsLocation, FileIO fileIO) throws UncheckedIOException {
186+
PositionOutputStream positionOutputStream;
187+
try {
188+
positionOutputStream = fileIO.newOutputFile(statsLocation).create();
189+
positionOutputStream.close();
190+
} catch (IOException e) {
191+
throw new UncheckedIOException(e);
202192
}
193+
194+
return ImmutableGenericPartitionStatisticsFile.builder()
195+
.snapshotId(snapshotId)
196+
.path(statsLocation)
197+
.fileSizeInBytes(42L)
198+
.build();
203199
}
204200
}

0 commit comments

Comments
 (0)