Skip to content

Commit 830c2b1

Browse files
committed
resolved comments
1 parent ad1f59f commit 830c2b1

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

lib/ClientConnection.cc

+1
Original file line numberDiff line numberDiff line change
@@ -1794,6 +1794,7 @@ void ClientConnection::handleTopicMigrated(const proto::CommandTopicMigrated& co
17941794
return;
17951795
}
17961796

1797+
Lock lock(mutex_);
17971798
if (commandTopicMigrated.resource_type() == proto::CommandTopicMigrated_ResourceType_Producer) {
17981799
auto it = producers_.find(resourceId);
17991800
if (it != producers_.end()) {

lib/ProducerImpl.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,8 @@ Future<Result, bool> ProducerImpl::connectionOpened(const ClientConnectionPtr& c
144144
return promise.getFuture();
145145
}
146146

147-
LOG_DEBUG("Creating producer" << topic() << "producerName: " << producerName_ << " on "
148-
<< cnx->cnxString());
147+
LOG_DEBUG("Creating producer for topic:" << topic() << ", producerName:" << producerName_ << " on "
148+
<< cnx->cnxString());
149149
ClientImplPtr client = client_.lock();
150150
cnx->registerProducer(producerId_, shared_from_this());
151151

proto/PulsarApi.proto

+1-1
Original file line numberDiff line numberDiff line change
@@ -622,7 +622,7 @@ message CommandReachedEndOfTopic {
622622
}
623623

624624
message CommandTopicMigrated {
625-
enum ResourceType {
625+
enum ResourceType {
626626
Producer = 0;
627627
Consumer = 1;
628628
}

tests/extensibleLM/ExtensibleLoadManagerTest.cc

+3-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,9 @@ TEST(ExtensibleLoadManagerTest, testPubSubWhileUnloading) {
7070
return res == 204 || res == 409;
7171
}));
7272

73-
Client client{"pulsar://localhost:6650"};
73+
ClientConfiguration conf;
74+
conf.setIOThreads(8);
75+
Client client{"pulsar://localhost:6650", conf};
7476
Producer producer;
7577
ProducerConfiguration producerConfiguration;
7678
Result producerResult = client.createProducer(topicName, producerConfiguration, producer);

0 commit comments

Comments
 (0)