Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest rewrite regexConsumer with inheritance #846

Open
labuladong opened this issue Sep 15, 2022 · 1 comment · May be fixed by #848
Open

Suggest rewrite regexConsumer with inheritance #846

labuladong opened this issue Sep 15, 2022 · 1 comment · May be fixed by #848

Comments

@labuladong
Copy link
Contributor

I'm working on the batch receive feature #840. But before that, I think simplifying the implementation of regexConsumer and multiTopicConsumer is necessary.

In Java client, PatternMultiTopicsConsumerImpl inherits from MultiTopicsConsumerImpl. But Go client implements multiTopicConsumer and regexConsumer separately for now.

I suggest rewriting regexConsumer with inheritance just like Java client. If so, further feature development could be easier.

Feel free to correct me if my understanding is inaccurate. cc @wolfstudy @merlimat @nodece
@labuladong labuladong linked a pull request Sep 16, 2022 that will close this issue
Open
1 task
@iamseki
Copy link

iamseki commented Oct 3, 2023

Any plans to get back to work on the batch receive feature? This seems like a really cool feature but is not available in the Go client 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[client] rewrite regexConsumer to avoid duplicate code labuladong/pulsar-client-go
2 participants
@labuladong @iamseki