Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Roles and Service Accounts #424

Closed
Mortom123 opened this issue Jan 11, 2024 · 2 comments
Closed

Optional Roles and Service Accounts #424

Mortom123 opened this issue Jan 11, 2024 · 2 comments
Assignees

Comments

@Mortom123
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Some cluster provider are strict with their roles / service accounts. A way to completely turn of Role creation, Role binding and Service Account creation (use the default service account provided in a namespace) would enable easier deployment in such scenarios.

Describe the solution you'd like
Add in values.yaml: rbac.use_default_account which toggles the aforementioned k8s kinds to not be deployed and instead use the default account provided (this could also be another option to set)

Describe alternatives you've considered
None

Additional context
Would be willing to submit a PR. :)

@lhotari
Copy link
Member

lhotari commented Jan 17, 2024

Usually the problem is the usage of ClusterRoles and ClusterRoleBindings. Those are no longer the default after #418 was merged. That change will be included in the chart's upcoming 3.2.0 release which is currently in voting stage.

What you are proposing most likely makes sense. I'm looking forward to your PR.

@Mortom123
Copy link
Contributor Author

After some more trial and error, it turns out that really just the (Cluster)Role and (Cluster)RoleBindings were the problem. ServiceAccount creation seems to be perfectly fine. Will close this Feature Request as it was made out of false assumptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants