Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulsar-proxy: tls Certname #527

Open
cccdemon opened this issue Sep 11, 2024 · 3 comments
Open

pulsar-proxy: tls Certname #527

cccdemon opened this issue Sep 11, 2024 · 3 comments

Comments

@cccdemon
Copy link

cccdemon commented Sep 11, 2024

Is your feature request related to a problem? Please describe.
When you want to use a valid / signed certificate for pulsar-proxy, the helm charts do not use the certname you entered in the values file:
Example:
proxy:
enabled: true
cert_name: my-valid-certificate # use this certname
createCert: false # set to false if you want to use an existing certificate

Results in certificate name within the Proxy as "pulsar-my-valid-certificate"

Describe the solution you'd like
just use the cert_name i`ve entered

Describe alternatives you've considered
remove the option of "using the releasename as prefix"

Additional context
File: proxy-statefulset.yaml

{{- if .Values.tls.proxy.createCert }}
secretName: "{{ .Release.Name }}-{{ .Values.tls.proxy.cert_name }}"
{{- else }}
secretName: "{{ .Values.tls.proxy.cert_name }}"
{{- end }}
@lhotari
Copy link
Member

lhotari commented Sep 19, 2024

@cccdemon Sounds like a useful improvement. Would you like to contribute a pull request? This Helm chart is community maintained so pull requests are preferred so that we can improve the chart together over time.

@cccdemon
Copy link
Author

@lhotari never did that, but I will give it a try :-)

@lhotari
Copy link
Member

lhotari commented Oct 18, 2024

@cccdemon There's #523 with a related change. That has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants