Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java client: batch messages - do not create a batch message of 1 single message #16547

Closed
eolivelli opened this issue Jul 12, 2022 · 2 comments
Closed
Assignees
Labels

Comments

@eolivelli
Copy link
Contributor

I think that we could implement a small but effective enhancement to batching.

It may happen that even if you enable batching you come to create entries with 1 only message.

Processing batch messages requires a good amount of resources, both on the broker and on the client side.

Especially when you are using PIP-105, Broker side filtering, you have to unpack (and decompress) the whole entry in order to process the very single message.

So my proposal is to change the (Java) producer, to make it produce a regular message instead of a batch message if the batch contains only 1 message.

Testing should cover:

  • regular batch sending using the Java producer
  • KEY based batcher builder
@AnonHxy
Copy link
Contributor

AnonHxy commented Jul 12, 2022

I am working on that, thanks

@github-actions
Copy link

The issue had no activity for 30 days, mark with Stale label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants