Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom properties for Tenants and Namespaces #19664

Open
1 of 2 tasks
eolivelli opened this issue Feb 28, 2023 · 4 comments
Open
1 of 2 tasks

Support custom properties for Tenants and Namespaces #19664

eolivelli opened this issue Feb 28, 2023 · 4 comments
Labels
Stale type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Comments

@eolivelli
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

In Pulsar 2.11 we can store custom properties in Topics and in Subscription.
We lack the ability to tag Tenants and Namespaces with custom properties.

Solution

Support setting a custom set of key-value pairs on Tenants and on Namespaces.

The map can be immutable

Alternatives

No response

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@eolivelli eolivelli added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Feb 28, 2023
@dao-jun
Copy link
Member

dao-jun commented Feb 28, 2023

related PIP: #12629

@michaeljmarshall
Copy link
Member

We'll need to consider authorization for these properties. Who has access to the get and modify these properties?

@michaeljmarshall
Copy link
Member

For reference, reading topic properties maps to the TopicOperation.GET_METADATA, which requires lookup permission for the topic. Updating or deleting that metadata require tenant admin or superuser privileges. Interestingly, any user that can create a topic can also create the initial properties map for that topic. That is technically inconsistent since a role could have permission to create a properties map but not update it later.

In the context of this feature, I think it seems reasonable for a tenant admin or superuser should be able to create/update/delete namespace properties, and I think a super user should be the only role that is able to create/update/delete tenant properties.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

The issue had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

No branches or pull requests

3 participants