Return exit code 1 when pulsar-admin commands fail

[SpencerC]

Search before asking

• I searched in the issues and found nothing similar.

Motivation

Run bin/pulsar-admin sources create --source-config-file doesnotexist.yaml && echo $?. The output clearly shows an error, but renders a success return code.

I just spent an hour debugging what turned out to be a spelling error. 😝

Solution

No response

Alternatives

No response

Anything else?

No response

Are you willing to submit a PR?

• I'm willing to submit a PR!

[JooHyukKim]

@SpencerC Are you working on this now?

[SpencerC]

Not at the moment

[JooHyukKim]

@SpencerC May I ask you to lemme know if you don't plan on solving this issue? 🙏🏼🙏🏼 I have some spare time and would like to try this out if ever.

[tisonkun]

Since @SpencerC doesn't tick the " I'm willing to submit a PR!", I believe @JooHyukKim you can continue to work on this ticket.

[JooHyukKim]

Since @SpencerC doesn't tick the " I'm willing to submit a PR!", I believe @JooHyukKim you can continue to work on this ticket.

I see, I assumed the checkbox was checked only because it existed 😅 Thank you @tisonkun !

[tisonkun]

I assumed the checkbox was checked only because it existed

That can be the case sometimes (or often), lol.

[SpencerC]

Thanks! I don't know the codebase that well yet, and thought this might be trivially easy for someone who did.