Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] PIP-380: Support-setting-up-specific-namespaces-to-skipping-the-load-shedding #23549

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Demogorgon314
Copy link
Member

PIP: PIP-380 #23304

Motivation

#23304

Modifications

Add a new configuration loadBalancerSheddingExcludedNamespaces to allow disabling the load balancer shedding for specific namespaces.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@Demogorgon314 Demogorgon314 self-assigned this Nov 4, 2024
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Nov 4, 2024
@Demogorgon314 Demogorgon314 marked this pull request as ready for review November 8, 2024 01:00
Copy link
Contributor

@heesung-sn heesung-sn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comments. otherwise LGTM.

@heesung-sn
Copy link
Contributor

@Demogorgon314
Copy link
Member Author

@heesung-sn Updated. PTAL again.

@heesung-sn
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required Your PR changes impact docs and you will update later. ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants