Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the python2.7 to python3.7 #8622

Closed
zymap opened this issue Nov 19, 2020 · 2 comments
Closed

Migrate the python2.7 to python3.7 #8622

zymap opened this issue Nov 19, 2020 · 2 comments
Assignees
Labels
area/client lifecycle/stale type/feature The PR added a new feature or issue requested a new feature

Comments

@zymap
Copy link
Member

zymap commented Nov 19, 2020

Motivation

PIP-56 proposed we should upgrade our python version in the Docker image, we did that in the PR #7963.
But I still find some python2.7 usage in the pulsar repository:

function module:
https://github.com/apache/pulsar/blob/master/pulsar-functions/scripts/python/generate.sh

cpp module:
https://github.com/apache/pulsar/blob/master/pulsar-client-cpp/CMakeLists.txt#L175
https://github.com/apache/pulsar/blob/master/pulsar-client-cpp/python/CMakeLists.txt#L40https://github.com/apache/pulsar/blob/master/pulsar-client-cpp/python/pkg/osx/vagrant-build.sh#L38

Should we remove them as well?

@BewareMyPower
Copy link
Contributor

The C++ related build and test scripts rely on the docker image apachepulsar/pulsar-build:ubuntu-16.04.

Dockerfiles under https://github.com/apache/pulsar/blob/master/pulsar-client-cpp/docker directory also need changes.

@BewareMyPower
Copy link
Contributor

It's already done by PIP-155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client lifecycle/stale type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
4 participants