Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LoggingUtils to move out codes related to logback #24727

Closed
zhfeng opened this issue Mar 22, 2023 · 0 comments · Fixed by #24730
Closed

Refactor LoggingUtils to move out codes related to logback #24727

zhfeng opened this issue Mar 22, 2023 · 0 comments · Fixed by #24730

Comments

@zhfeng
Copy link
Contributor

zhfeng commented Mar 22, 2023

Feature Request

For English only, other languages will not be accepted.

Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Is your feature request related to a problem?

When compling quarkus-shardingsphere-jdbc in native mode, I need to exclude ch.qos.logback since it could conflict with the quarkus logging libraries, see https://cn.quarkus.io/guides/logging#logging-adapters.

I met some failures like

========================================================================================================================
GraalVM Native Image: Generating 'quarkus-shardingsphere-jdbc-integration-tests-1.x-999-SNAPSHOT-runner' (executable)...
========================================================================================================================

[1/7] Initializing...                                                                                    (0.0s @ 0.46GB)
Error: Cannot find org.apache.shardingsphere.logging.utils.LoggingUtils.refreshLogger, org.apache.shardingsphere.logging.utils.LoggingUtils can not be loaded, due to ch/qos/logback/core/encoder/Encoder not being available in the classpath. Are you missing a dependency in your classpath?
com.oracle.svm.core.util.UserError$UserException: Cannot find org.apache.shardingsphere.logging.utils.LoggingUtils.refreshLogger, org.apache.shardingsphere.logging.utils.LoggingUtils can not be loaded, due to ch/qos/logback/core/encoder/Encoder not being available in the classpath. Are you missing a dependency in your classpath?

Describe the feature you would like.

I'd like to do some changes in LoggingUtils to move out codes related to logback, it could be refreshLogger method which has not been used as far as I know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants