Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shardingsphere-jdbc-governance incompatible with druid-spring-boot-starter #8940

Closed
TeslaCN opened this issue Jan 7, 2021 · 4 comments
Closed

Comments

@TeslaCN
Copy link
Member

TeslaCN commented Jan 7, 2021

Feature Request

The DataSourceConfiguration requires public no-args constructor on DataSource. But the druid-spring-boot-starter create a class named DruidDataSourceWrapper extends DruidDataSource, but without public no-args constructor.

https://github.com/alibaba/druid/blob/5761dccf904c1fe8120767f86d67ccf0be171726/druid-spring-boot-starter/src/main/java/com/alibaba/druid/spring/boot/autoconfigure/DruidDataSourceWrapper.java#L32

If we used the druid starter, an exception
java.lang.NoSuchMethodException: com.alibaba.druid.spring.boot.autoconfigure.DruidDataSourceWrapper.<init>()
will occurred when invoking org.apache.shardingsphere.infra.config.datasource.DataSourceConfiguration#createDataSource.

@yu199195
Copy link
Member

yu199195 commented Feb 4, 2021

hi, you will see this : #1900

@TeslaCN
Copy link
Member Author

TeslaCN commented Feb 4, 2021

Hi @yu199195
I think this issue is different with #1900. This issue is failed to instantiate a DataSource without no-args constructor.

@linghengqian
Copy link
Member

linghengqian commented Feb 25, 2022

Caused by the situation mentioned in alibaba/druid#4673?

update: Maybe I understand is wrong, the problem on alibaba/druid#4481 by simple processing. This problem can be addressed in Druid 1.2.8.

@TeslaCN
Copy link
Member Author

TeslaCN commented Mar 21, 2022

Fixed since Druid 1.2.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants