Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failure enabling TLS in Docker distro of OAP server 8.1.0-es7 #5518

Closed
1 of 4 tasks
pantovad opened this issue Sep 18, 2020 · 6 comments · Fixed by apache/skywalking-docker#11
Closed
1 of 4 tasks
Assignees
Labels
backend OAP backend related. bug Something isn't working and you are sure it's a bug! docker Docker build scripts or images related
Milestone

Comments

@pantovad
Copy link

pantovad commented Sep 18, 2020

Please answer these questions before submitting your issue.

  • Why do you submit this issue?
  • Question or discussion
  • Bug
  • Requirement
  • Feature or performance improvement

Question

  • What do you want to know?

Bug


Requirement or improvement

  • I managed to resolve the issue by using adoptopenjdk/openjdk11:alpine (instead of openjdk:8-jre-alpine) as base Java image for both base and OAP image.
@wu-sheng wu-sheng added the backend OAP backend related. label Sep 18, 2020
@hanahmily
Copy link
Contributor

it's because netty tc-native needs some dynamic libraries which apline doesn't contain. we should release a new base image to adopt to "jdk" instead of "jre".

Since OAP can work fine with jdk11, I prefer to use it as the new base image.
@wu-sheng @kezhenxu94 ^^

@wu-sheng
Copy link
Member

Work for me. Please update the docker file in the main repo first.

@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! docker Docker build scripts or images related labels Sep 20, 2020
@wu-sheng wu-sheng added this to the 8.2.0 milestone Sep 20, 2020
@hanahmily
Copy link
Contributor

Work for me. Please update the docker file in the main repo first.

main repo doesn't have this issue and uses the jdk based image all the time due to our development and debugging requirement.

@wu-sheng
Copy link
Member

@innerpeacez I added this to the k8s release milestone for next version, in case we miss this in next time.

@hanahmily Do you plan to push the 8.1.0 images again for jdk binded?

@pantovad I will recommend you to re package first locally.

@kezhenxu94
Copy link
Member

kezhenxu94 commented Oct 25, 2020

And now, when testing #5722 , I've also found that it(Kubernetes Java client) doesn't work well on openjdk:8-jdk (see kubernetes-client/java#1003 although it just happens in Minikube), thus I used openjdk:11-jdk for the tests, I suggest to upgrade the JDK version in the base image ASAP

@wu-sheng
Copy link
Member

JDK11 as next TLS, make sense to me. Just feel strange, why JDK version matters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. bug Something isn't working and you are sure it's a bug! docker Docker build scripts or images related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants