Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support real equalMatch in OAL core #7521

Closed
wu-sheng opened this issue Aug 20, 2021 Discussed in #7517 · 5 comments · Fixed by #7636
Closed

Support real equalMatch in OAL core #7521

wu-sheng opened this issue Aug 20, 2021 Discussed in #7517 · 5 comments · Fixed by #7636
Assignees
Labels
backend OAP backend related. feature New feature good first issue Good first issue for beginners
Milestone

Comments

@wu-sheng
Copy link
Member

Discussed in #7517

Originally posted by 807801002 August 20, 2021
Which field can be used at filter()?I thought all fields in org.apache.skywalking.oap.server.core.source.ServiceRelation can be used to the filter expression for "from(ServiceRelation.*)".But the "componentId == 7" is error. which is a field at ServiceRelation.
Snipaste_2021-08-20_17-20-14

We have EqualMatch(function name, stringMatch), but this is for String type only. We should add a real equalMatch function in grammar tree and implementation in org.apache.skywalking.oap.server.core.analysis.metrics.expression.
Also, we should rename class EqualMatch to StringMatch.

@wu-sheng wu-sheng added backend OAP backend related. feature New feature good first issue Good first issue for beginners labels Aug 20, 2021
@YczYanchengzhe
Copy link
Contributor

I want to implement this by adding intmatch and wonder if it assign assigned to me

@kezhenxu94
Copy link
Member

@YczYanchengzhe assigned, thanks

@YczYanchengzhe
Copy link
Contributor

I encountered a problem.
After I completed the development and passed the unit test, I wanted to run the integration and found this error. The cause of the error was that the oal.core included parameter configuration could not be recognized. What could be the reason for this?

line 23:46 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 24:42 mismatched input '100' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 30:54 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 40:120 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 41:120 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 50:137 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 51:137 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 62:56 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 68:118 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}
line 73:69 extraneous input '10' expecting {')', BOOL_LITERAL, NUMBER_LITERAL, IDENTIFIER}

@YczYanchengzhe
Copy link
Contributor

image

@wu-sheng
Copy link
Member Author

wu-sheng commented Sep 1, 2021

You should change antlr file, and oal core to generate correct class codes. I am feeling you don't change them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. feature New feature good first issue Good first issue for beginners
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants