Add shareProcessNamespace flag to podOptions #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boolean flag defaults unset, and is available in the CRD at `.spec.customSolrKubeOptions.podOptions.shareProcessNamespace`
gerlowskija
commented
Dec 12, 2024
|
This PR should allow us to close #716 |
This reverts commit c5082af.
Oh, ok - I didn't realize we exposed every podOption there, but I guess that makes sense. We still only want a Chart.yaml change-entry in the solr-operator helm chart I assume, per the in-line discussion above? (Reminder to self: helm changes still need tested) |
|
Alright, I think I addressed all your feedback @HoustonPutman , and I've tested out my changes to the 'solr' chart since my previous comment. So this should be good to merge; I'll aim to do so shortly unless there's further feedback. |
HoustonPutman
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolean flag defaults unset, and is available in the CRD at
.spec.customSolrKubeOptions.podOptions.shareProcessNamespace