Skip to content

Commit 13a58c6

Browse files
committed
deduplicate a bit
1 parent e74e6d9 commit 13a58c6

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnvSuite.scala

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,24 +49,22 @@ class SparkSQLEnvSuite extends SparkFunSuite {
4949
}
5050

5151
private def withSystemProperties(pairs: (String, String)*)(f: => Unit): Unit = {
52-
val oldValues = pairs.map { kv => kv._1 -> System.getProperty(kv._1) }.toMap
53-
try {
54-
pairs.foreach { case (key, value) =>
52+
def setProperties(properties: Seq[(String, String)]): Unit = {
53+
properties.foreach { case (key, value) =>
5554
if (value != null) {
5655
System.setProperty(key, value)
5756
} else {
5857
System.clearProperty(key)
5958
}
6059
}
60+
}
61+
62+
val oldValues = pairs.map { kv => kv._1 -> System.getProperty(kv._1) }
63+
try {
64+
setProperties(pairs)
6165
f
6266
} finally {
63-
oldValues.foreach { case (key, value) =>
64-
if (value != null) {
65-
System.setProperty(key, value)
66-
} else {
67-
System.clearProperty(key)
68-
}
69-
}
67+
setProperties(oldValues)
7068
}
7169
}
7270
}

0 commit comments

Comments
 (0)