Skip to content

Commit 487da8f

Browse files
committed
SPARK-18252: Fixing RAT style errors
1 parent 66f58d1 commit 487da8f

File tree

6 files changed

+8
-15
lines changed

6 files changed

+8
-15
lines changed

common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,4 +233,4 @@ public static BloomFilter create(long expectedNumItems, long numBits) {
233233

234234
return new BloomFilterImpl(optimalNumOfHashFunctions(expectedNumItems, numBits), numBits);
235235
}
236-
}
236+
}

common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilterImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,4 +253,4 @@ private void writeObject(ObjectOutputStream out) throws IOException {
253253
private void readObject(ObjectInputStream in) throws IOException {
254254
readFrom0(in);
255255
}
256-
}
256+
}

common/sketch/src/main/java/org/apache/spark/util/sketch/Murmur3_128.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,4 +147,4 @@ private static long mixK2(long k2) {
147147
k2 *= C1;
148148
return k2;
149149
}
150-
}
150+
}

common/sketch/src/test/java/org/apache/spark/util/sketch/Murmur3_128Suite.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,4 @@ private static void assertHash(int seed, long expected1, long expected2, String
4747
Assert.assertEquals(expected1, hash128bit[0]);
4848
Assert.assertEquals(expected2, hash128bit[1]);
4949
}
50-
}
50+
}

common/sketch/src/test/scala/org/apache/spark/util/sketch/BloomFilterSuite.scala

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,7 @@ class BloomFilterSuite extends FunSuite { // scalastyle:ignore funsuite
130130
}
131131
}
132132

133-
/**
134-
* Instead of random generator we can check
135-
* BloomFilter for every Byte value
136-
* since it has only 256 values
137-
*/
133+
// Separate test for Byte type, since we can enumerate all possible values
138134
test(s"accuracy - Byte") {
139135
// Byte is from -128 to 127 inclusive
140136
val allBytes = (-128 to 127).map(_.toByte)
@@ -162,10 +158,7 @@ class BloomFilterSuite extends FunSuite { // scalastyle:ignore funsuite
162158
checkSerDe(filter)
163159
}
164160

165-
/**
166-
* Separate test for Byte type,
167-
* Since we can enumerate all possible values
168-
*/
161+
// Separate test for Byte type, since we can enumerate all possible values
169162
test(s"mergeInPlace - Byte") {
170163
val allBytes = (-128 to 127).map(_.toByte)
171164
val fpp = 0.05
@@ -191,4 +184,4 @@ class BloomFilterSuite extends FunSuite { // scalastyle:ignore funsuite
191184

192185
checkSerDe(filter1)
193186
}
194-
}
187+
}

common/sketch/src/test/scala/org/apache/spark/util/sketch/RoaringBitmapArraySuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,4 @@ class RoaringBitmapArraySuite extends FunSuite { // scalastyle:ignore funsuite
6565
indexes2.foreach(i => assert(bitArray1.get(i)))
6666
assert(bitArray1.cardinality() == (indexes1 ++ indexes2).distinct.length)
6767
}
68-
}
68+
}

0 commit comments

Comments
 (0)