Skip to content

Commit 5e9dbcc

Browse files
committed
more tests
1 parent 903adc9 commit 5e9dbcc

File tree

4 files changed

+16
-14
lines changed

4 files changed

+16
-14
lines changed

sql/core/src/test/scala/org/apache/spark/sql/SQLContextSuite.scala

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,11 @@ class SQLContextSuite extends SparkFunSuite with SharedSparkContext {
8888
df.createOrReplaceTempView("listtablessuitetable")
8989
assert(
9090
sqlContext.tables().filter("tableName = 'listtablessuitetable'").collect().toSeq ==
91-
Row("", "listtablessuitetable", true) :: Nil)
91+
Row("", "listtablessuitetable", true, "VIEW") :: Nil)
9292

9393
assert(
9494
sqlContext.sql("SHOW tables").filter("tableName = 'listtablessuitetable'").collect().toSeq ==
95-
Row("", "listtablessuitetable", true) :: Nil)
95+
Row("", "listtablessuitetable", true, "VIEW") :: Nil)
9696

9797
sqlContext.sessionState.catalog.dropTable(
9898
TableIdentifier("listtablessuitetable"), ignoreIfNotExists = true, purge = false)
@@ -105,11 +105,11 @@ class SQLContextSuite extends SparkFunSuite with SharedSparkContext {
105105
df.createOrReplaceTempView("listtablessuitetable")
106106
assert(
107107
sqlContext.tables("default").filter("tableName = 'listtablessuitetable'").collect().toSeq ==
108-
Row("", "listtablessuitetable", true) :: Nil)
108+
Row("", "listtablessuitetable", true, "VIEW") :: Nil)
109109

110110
assert(
111111
sqlContext.sql("show TABLES in default").filter("tableName = 'listtablessuitetable'")
112-
.collect().toSeq == Row("", "listtablessuitetable", true) :: Nil)
112+
.collect().toSeq == Row("", "listtablessuitetable", true, "VIEW") :: Nil)
113113

114114
sqlContext.sessionState.catalog.dropTable(
115115
TableIdentifier("listtablessuitetable"), ignoreIfNotExists = true, purge = false)
@@ -124,7 +124,8 @@ class SQLContextSuite extends SparkFunSuite with SharedSparkContext {
124124
val expectedSchema = StructType(
125125
StructField("namespace", StringType, false) ::
126126
StructField("tableName", StringType, false) ::
127-
StructField("isTemporary", BooleanType, false) :: Nil)
127+
StructField("isTemporary", BooleanType, false) ::
128+
StructField("tableType", StringType, false) :: Nil)
128129

129130
Seq(sqlContext.tables(), sqlContext.sql("SHOW TABLes")).foreach {
130131
case tableDF =>

sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1879,7 +1879,8 @@ class DataSourceV2SQLSuite
18791879
test("rename table by ALTER VIEW") {
18801880
withTable("testcat.ns1.new") {
18811881
sql("CREATE TABLE testcat.ns1.ns2.old USING foo AS SELECT id, data FROM source")
1882-
checkAnswer(sql("SHOW TABLES FROM testcat.ns1.ns2"), Seq(Row("ns1.ns2", "old", false)))
1882+
checkAnswer(sql("SHOW TABLES FROM testcat.ns1.ns2"),
1883+
Seq(Row("ns1.ns2", "old", false, "TABLE")))
18831884

18841885
val e = intercept[AnalysisException] {
18851886
sql("ALTER VIEW testcat.ns1.ns2.old RENAME TO ns1.new")
@@ -2602,7 +2603,7 @@ class DataSourceV2SQLSuite
26022603
sql(s"ALTER TABLE $tbl RENAME TO new_tbl")
26032604
checkAnswer(
26042605
sql(s"SHOW TABLES FROM testcat.ns1.ns2 LIKE 'new_tbl'"),
2605-
Row("ns1.ns2", "new_tbl", false))
2606+
Row("ns1.ns2", "new_tbl", false, "TABLE"))
26062607
checkAnswer(sql(s"SELECT c0 FROM ${catalogAndNamespace}new_tbl"), Row(0))
26072608
}
26082609
}

sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
6868
}
6969

7070
test("show tables") {
71-
checkAnswer(sql("SHOW TABLES IN h2.test"), Seq(Row("test", "people", false)))
71+
checkAnswer(sql("SHOW TABLES IN h2.test"), Seq(Row("test", "people", false, "TABLE")))
7272
// Check not existing namespace
7373
checkAnswer(sql("SHOW TABLES IN h2.bad_test"), Seq())
7474
}
@@ -78,9 +78,9 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
7878
conn.prepareStatement("""CREATE TABLE "test"."to_drop" (id INTEGER)""").executeUpdate()
7979
}
8080
checkAnswer(sql("SHOW TABLES IN h2.test"),
81-
Seq(Row("test", "to_drop", false), Row("test", "people", false)))
81+
Seq(Row("test", "to_drop", false, "TABLE"), Row("test", "people", false, "TABLE")))
8282
sql("DROP TABLE h2.test.to_drop")
83-
checkAnswer(sql("SHOW TABLES IN h2.test"), Seq(Row("test", "people", false)))
83+
checkAnswer(sql("SHOW TABLES IN h2.test"), Seq(Row("test", "people", false, "TABLE")))
8484
Seq(
8585
"h2.test.not_existing_table" ->
8686
"Table or view not found: h2.test.not_existing_table",
@@ -101,11 +101,11 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
101101
}
102102
checkAnswer(
103103
sql("SHOW TABLES IN h2.test"),
104-
Seq(Row("test", "src_table", false), Row("test", "people", false)))
104+
Seq(Row("test", "src_table", false, "TABLE"), Row("test", "people", false, "TABLE")))
105105
sql("ALTER TABLE h2.test.src_table RENAME TO test.dst_table")
106106
checkAnswer(
107107
sql("SHOW TABLES IN h2.test"),
108-
Seq(Row("test", "dst_table", false), Row("test", "people", false)))
108+
Seq(Row("test", "dst_table", false, "TABLE"), Row("test", "people", false, "TABLE")))
109109
}
110110
// Rename not existing table or namespace
111111
val exp1 = intercept[AnalysisException] {
@@ -156,7 +156,7 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
156156
sql("CREATE TABLE h2.test.new_table(i INT, j STRING)")
157157
checkAnswer(
158158
sql("SHOW TABLES IN h2.test"),
159-
Seq(Row("test", "people", false), Row("test", "new_table", false)))
159+
Seq(Row("test", "people", false, "TABLE"), Row("test", "new_table", false, "TABLE")))
160160
}
161161
withTable("h2.test.new_table") {
162162
sql("CREATE TABLE h2.test.new_table(i INT, j STRING)")

sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession {
145145

146146
test("show tables") {
147147
checkAnswer(sql("SHOW TABLES IN h2.test"),
148-
Seq(Row("test", "people", false), Row("test", "empty_table", false)))
148+
Seq(Row("test", "people", false, "TABLE"), Row("test", "empty_table", false, "TABLE")))
149149
}
150150

151151
test("SQL API: create table as select") {

0 commit comments

Comments
 (0)