Skip to content

Commit 94fb546

Browse files
committed
mv to SQLViewSuite
1 parent 32ec11a commit 94fb546

File tree

2 files changed

+16
-14
lines changed

2 files changed

+16
-14
lines changed

sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -738,6 +738,21 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils {
738738
}
739739

740740
test("SPARK-32356: forbid null type in create view") {
741+
// test sql
742+
val sql1 = "create view v as select null as c"
743+
val sql2 = "alter view v as select null as c"
744+
val sql3 = "create temporary view v as select null as c"
745+
val sql4 = "create global temporary view v as select null as c"
746+
Seq(sql1, sql2, sql3, sql4).foreach { input =>
747+
val msg = intercept[AnalysisException] {
748+
sql(input)
749+
}.getMessage
750+
assert(msg.contains(s"Cannot create tables/views with ${NullType.simpleString} type."))
751+
}
752+
}
753+
754+
test("SPARK-32356: forbid null type in create view") {
755+
// test df.createTempView
741756
val msg = intercept[AnalysisException] {
742757
sql("select null as c").createTempView("null_type_view")
743758
}.getMessage

sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ import org.apache.spark.sql.execution.datasources.CreateTable
3838
import org.apache.spark.sql.execution.datasources.v2.DataSourceV2Relation
3939
import org.apache.spark.sql.internal.SQLConf
4040
import org.apache.spark.sql.sources.SimpleScanSource
41-
import org.apache.spark.sql.types.{CharType, DoubleType, HIVE_TYPE_STRING, IntegerType, LongType, MetadataBuilder, NullType, StringType, StructField, StructType}
41+
import org.apache.spark.sql.types.{CharType, DoubleType, HIVE_TYPE_STRING, IntegerType, LongType, MetadataBuilder, StringType, StructField, StructType}
4242

4343
class PlanResolutionSuite extends AnalysisTest {
4444
import CatalystSqlParser._
@@ -1557,19 +1557,6 @@ class PlanResolutionSuite extends AnalysisTest {
15571557
checkFailure("testcat.tab", "foo")
15581558
}
15591559

1560-
test("SPARK-32356: forbid null type in create view") {
1561-
val sql1 = "create view v as select null as c"
1562-
val sql2 = "alter view v as select null as c"
1563-
val sql3 = "create temporary view v as select null as c"
1564-
val sql4 = "create global temporary view v as select null as c"
1565-
Seq(sql1, sql2, sql3, sql4).foreach { sql =>
1566-
val msg = intercept[AnalysisException] {
1567-
parseAndResolve(sql)
1568-
}.getMessage
1569-
assert(msg.contains(s"Cannot create tables/views with ${NullType.simpleString} type."))
1570-
}
1571-
}
1572-
15731560
// TODO: add tests for more commands.
15741561
}
15751562

0 commit comments

Comments
 (0)