Skip to content

Commit 984e69b

Browse files
committed
Hive 0.12 JDBC client cannot read binary type
1 parent a59fdc4 commit 984e69b

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkThriftServerProtocolVersionsSuite.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,7 @@ class SparkThriftServerProtocolVersionsSuite extends HiveThriftJdbcTest {
215215
}
216216
}
217217

218-
// TODO: enable this test case after SPARK-28474
219-
ignore(s"$version get binary type") {
218+
test(s"$version get binary type") {
220219
testExecuteStatementWithProtocolVersion(version, "SELECT cast('ABC' as binary)") { rs =>
221220
assert(rs.next())
222221
assert(rs.getString(1) === "ABC")

sql/hive-thriftserver/v1.2.1/src/main/java/org/apache/hive/service/cli/ColumnValue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ public static TColumnValue toTColumnValue(Type type, Object value) {
195195
case DECIMAL_TYPE:
196196
return stringValue(((HiveDecimal)value));
197197
case BINARY_TYPE:
198-
return stringValue((String)value);
198+
return stringValue(new String((byte[])value));
199199
case ARRAY_TYPE:
200200
case MAP_TYPE:
201201
case STRUCT_TYPE:

sql/hive-thriftserver/v2.3.5/src/main/java/org/apache/hive/service/cli/ColumnValue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ public static TColumnValue toTColumnValue(TypeDescriptor typeDescriptor, Object
199199
case DECIMAL_TYPE:
200200
return stringValue((HiveDecimal)value, typeDescriptor);
201201
case BINARY_TYPE:
202-
return stringValue((String)value);
202+
return stringValue(new String((byte[])value));
203203
case ARRAY_TYPE:
204204
case MAP_TYPE:
205205
case STRUCT_TYPE:

0 commit comments

Comments
 (0)