Skip to content

Commit aa3bc5b

Browse files
committed
add draft
1 parent ffe3fc9 commit aa3bc5b

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateTableExec.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ case class ShowCreateTableExec(
109109
s"'${escapeSingleQuotedString(key)}' = '${escapeSingleQuotedString(value)}'"
110110
}
111111

112-
builder ++= "TBLPROPERTIES"
112+
builder ++= "TBLPROPERTIES "
113113
builder ++= concatByMultiLines(props)
114114
}
115115
}

sql/core/src/test/scala/org/apache/spark/sql/CharVarcharTestSuite.scala

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -843,16 +843,6 @@ class FileSourceCharVarcharTestSuite extends CharVarcharTestSuite with SharedSpa
843843
}
844844
}
845845

846-
// TODO(SPARK-33898): Move these tests to super after SHOW CREATE TABLE for v2 implemented
847-
test("SPARK-33892: SHOW CREATE TABLE w/ char/varchar") {
848-
withTable("t") {
849-
sql(s"CREATE TABLE t(v VARCHAR(3), c CHAR(5)) USING $format")
850-
val rest = sql("SHOW CREATE TABLE t").head().getString(0)
851-
assert(rest.contains("VARCHAR(3)"))
852-
assert(rest.contains("CHAR(5)"))
853-
}
854-
}
855-
856846
test("SPARK-34114: should not trim right for read-side length check and char padding") {
857847
Seq("char", "varchar").foreach { typ =>
858848
withTempPath { dir =>

sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2031,7 +2031,7 @@ class DataSourceV2SQLSuite
20312031
"PARTITIONED BY (a)",
20322032
"COMMENT 'This is a comment'",
20332033
"LOCATION 'file:/tmp'",
2034-
"TBLPROPERTIES(",
2034+
"TBLPROPERTIES (",
20352035
"'prop1' = '1',",
20362036
"'prop2' = '2',",
20372037
"'prop3' = '3',",

sql/core/src/test/scala/org/apache/spark/sql/execution/command/CharVarcharDDLTestBase.scala

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,15 @@ trait CharVarcharDDLTestBase extends QueryTest with SQLTestUtils {
160160
Row("char(5)"))
161161
}
162162
}
163+
164+
test("SPARK-33892: SHOW CREATE TABLE w/ char/varchar") {
165+
withTable("t") {
166+
sql(s"CREATE TABLE t(v VARCHAR(3), c CHAR(5)) USING $format")
167+
val rest = sql("SHOW CREATE TABLE t").head().getString(0)
168+
assert(rest.contains("VARCHAR(3)"))
169+
assert(rest.contains("CHAR(5)"))
170+
}
171+
}
163172
}
164173

165174
class FileSourceCharVarcharDDLTestSuite extends CharVarcharDDLTestBase with SharedSparkSession {

0 commit comments

Comments
 (0)