Skip to content

Commit b112528

Browse files
alkiscloud-fan
authored andcommitted
[SPARK-38569][BUILD] Rename external top level dir to connector
### What changes were proposed in this pull request? Rename the `external` top level directory to `connector`. ### Why are the changes needed? `external` is a hardwired special name for bazel and this causes all sorts of issues with both native bazel or extensions like [bazel-compile-commands-extractor](https://github.com/hedronvision/bazel-compile-commands-extractor). Spark forks using bazel to build Spark have to go through hoops to make things work if at all. Amongst other things, making the source code browsable [through top level `external` symlink]( https://github.com/hedronvision/bazel-compile-commands-extractor#make-external-code-easily-browsable-also-necessary-for-this-tool-to-function-correctly) is impossible with a top level `external` directory in the repository. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Ran `./build/mvn -DskipTests clean package` and `./dev/run-tests`. Closes #35874 from alkis/external-mv. Authored-by: Alkis Evlogimenos <alkis.evlogimenos@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
1 parent 53908be commit b112528

File tree

246 files changed

+15
-15
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

246 files changed

+15
-15
lines changed

R/run-tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ FAILED=0
2323
LOGFILE=$FWDIR/unit-tests.out
2424
rm -f $LOGFILE
2525

26-
SPARK_AVRO_JAR_PATH=$(find $FWDIR/../external/avro/ -name "spark-avro*jar" -print | egrep -v "tests.jar|test-sources.jar|sources.jar|javadoc.jar")
26+
SPARK_AVRO_JAR_PATH=$(find $FWDIR/../connector/avro/ -name "spark-avro*jar" -print | egrep -v "tests.jar|test-sources.jar|sources.jar|javadoc.jar")
2727

2828
if [[ $(echo $SPARK_AVRO_JAR_PATH | wc -l) -eq 1 ]]; then
2929
SPARK_JARS=$SPARK_AVRO_JAR_PATH

external/avro/benchmarks/AvroReadBenchmark-jdk11-results.txt renamed to connector/avro/benchmarks/AvroReadBenchmark-jdk11-results.txt

File renamed without changes.

external/avro/benchmarks/AvroReadBenchmark-jdk17-results.txt renamed to connector/avro/benchmarks/AvroReadBenchmark-jdk17-results.txt

File renamed without changes.

external/avro/benchmarks/AvroReadBenchmark-results.txt renamed to connector/avro/benchmarks/AvroReadBenchmark-results.txt

File renamed without changes.

external/avro/benchmarks/AvroWriteBenchmark-jdk11-results.txt renamed to connector/avro/benchmarks/AvroWriteBenchmark-jdk11-results.txt

File renamed without changes.

external/avro/benchmarks/AvroWriteBenchmark-jdk17-results.txt renamed to connector/avro/benchmarks/AvroWriteBenchmark-jdk17-results.txt

File renamed without changes.

external/avro/benchmarks/AvroWriteBenchmark-results.txt renamed to connector/avro/benchmarks/AvroWriteBenchmark-results.txt

File renamed without changes.

external/avro/src/main/java/org/apache/spark/sql/avro/SparkAvroKeyOutputFormat.java renamed to connector/avro/src/main/java/org/apache/spark/sql/avro/SparkAvroKeyOutputFormat.java

File renamed without changes.

external/avro/src/main/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister renamed to connector/avro/src/main/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister

File renamed without changes.

0 commit comments

Comments
 (0)