Address comments.

Author: dongjoon-hyun

sql/hive/src/test/scala/org/apache/spark/sql/catalyst/LogicalPlanToSQLSuite.scala

@@ -40,7 +40,8 @@ class LogicalPlanToSQLSuite extends SQLBuilderTest with SQLTestUtils {
   import testImplicits._
 
   // Used for generating new query answer files by saving
-  private val saveQuery = System.getenv("SPARK_GENERATE_GOLDEN_FILES") != null
+  private val regenerateGoldenFiles =
+    Option(System.getenv("SPARK_GENERATE_GOLDEN_FILES")).contains("1")
   private val goldenSQLPath = "src/test/resources/sqlgen/"
 
   protected override def beforeAll(): Unit = {
@@ -102,7 +103,7 @@ class LogicalPlanToSQLSuite extends SQLBuilderTest with SQLTestUtils {
     val normalizedGenSQL = convertedSQL.replaceAll("`gen_attr_\\d+`", "`gen_attr`")
     if (answerFile != null) {
       val separator = "-" * 80
-      if (saveQuery) {
+      if (regenerateGoldenFiles) {
         val path = Paths.get(s"$goldenSQLPath/$answerFile.sql")
         val header = "-- This file is automatically generated by LogicalPlanToSQLSuite."
         val answerText = s"$header\n${originalSQL.trim()}\n${separator}\n$normalizedGenSQL\n"
@@ -166,7 +167,7 @@ class LogicalPlanToSQLSuite extends SQLBuilderTest with SQLTestUtils {
   }
 
   // When saving golden files, these tests should be ignored to prevent making files.
-  if (!saveQuery) {
+  if (!regenerateGoldenFiles) {
     test("Test should fail if the SQL query cannot be parsed") {
       val m = intercept[ParseException] {
         checkSQL("SELE", "NOT_A_FILE")