Skip to content

[SPARK][STREAMING] Invoke onBatchCompletion() only when all jobs in the JobSet are Success #19824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiasheng55 wants to merge 2 commits into from
Closed

[SPARK][STREAMING] Invoke onBatchCompletion() only when all jobs in the JobSet are Success #19824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aafe7b6
Revert "[SPARK-18905][STREAMING] Fix the issue of removing a failed j…
Nov 27, 2017
e4e57cc
[SPARK][STREAMING] Invoke onBatchCompletion() only when all jobs in t…
Nov 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions streaming/src/main/scala/org/apache/spark/streaming/scheduler/JobScheduler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,20 +201,18 @@ class JobScheduler(val ssc: StreamingContext) extends Logging {
listenerBus.post(StreamingListenerOutputOperationCompleted(job.toOutputOperationInfo))
logInfo("Finished job " + job.id + " from job set of time " + jobSet.time)
if (jobSet.hasCompleted) {
jobSets.remove(jobSet.time)
jobGenerator.onBatchCompletion(jobSet.time)
logInfo("Total delay: %.3f s for time %s (execution: %.3f s)".format(
jobSet.totalDelay / 1000.0, jobSet.time.toString,
jobSet.processingDelay / 1000.0
))
listenerBus.post(StreamingListenerBatchCompleted(jobSet.toBatchInfo))
}
job.result match {
case Failure(e) =>
reportError("Error running job " + job, e)
case _ =>
if (jobSet.hasCompleted) {
jobSets.remove(jobSet.time)
jobGenerator.onBatchCompletion(jobSet.time)
logInfo("Total delay: %.3f s for time %s (execution: %.3f s)".format(
jobSet.totalDelay / 1000.0, jobSet.time.toString,
jobSet.processingDelay / 1000.0
))
}
}
}

Expand Down
4 changes: 3 additions & 1 deletion streaming/src/main/scala/org/apache/spark/streaming/scheduler/JobSet.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ case class JobSet(
}

def handleJobCompletion(job: Job) {
incompleteJobs -= job
if (job.result.isSuccess) {
incompleteJobs -= job
}
if (hasCompleted) processingEndTime = System.currentTimeMillis()
}

Expand Down