Skip to content

Commit c3b6feb

Browse files
committed
chore(read_csv): remove deprecated argument
1 parent 0e17e4b commit c3b6feb

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

superset/templates/superset/form_view/csv_to_database_view/edit.html

-4
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,6 @@
6868
{{ lib.render_field(form.parse_dates, begin_sep_label, end_sep_label,
6969
begin_sep_field, end_sep_field) }}
7070
</tr>
71-
<tr>
72-
{{ lib.render_field(form.infer_datetime_format, begin_sep_label,
73-
end_sep_label, begin_sep_field, end_sep_field) }}
74-
</tr>
7571
<tr>
7672
{{ lib.render_field(form.day_first, begin_sep_label, end_sep_label,
7773
begin_sep_field, end_sep_field) }}

superset/views/database/forms.py

-4
Original file line numberDiff line numberDiff line change
@@ -197,10 +197,6 @@ class CsvToDatabaseForm(UploadToDatabaseForm):
197197
),
198198
filters=[filter_not_empty_values],
199199
)
200-
infer_datetime_format = BooleanField(
201-
_("Interpret Datetime Format Automatically"),
202-
description=_("Interpret the datetime format automatically"),
203-
)
204200
day_first = BooleanField(
205201
_("Day First"),
206202
description=_("DD/MM format dates, international and European format"),

superset/views/database/views.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,6 @@ def form_get(self, form: CsvToDatabaseForm) -> None:
167167
form.overwrite_duplicate.data = True
168168
form.skip_initial_space.data = False
169169
form.skip_blank_lines.data = True
170-
form.infer_datetime_format.data = True
171170
form.day_first.data = False
172171
form.decimal.data = "."
173172
form.if_exists.data = "fail"
@@ -192,14 +191,14 @@ def form_post(self, form: CsvToDatabaseForm) -> Response:
192191

193192
try:
194193
kwargs = {"dtype": json.loads(form.dtype.data)} if form.dtype.data else {}
194+
print("\n\nHERE")
195195
df = pd.concat(
196196
pd.read_csv(
197197
chunksize=1000,
198198
encoding="utf-8",
199199
filepath_or_buffer=form.csv_file.data,
200200
header=form.header.data if form.header.data else 0,
201201
index_col=form.index_col.data,
202-
infer_datetime_format=form.infer_datetime_format.data,
203202
dayfirst=form.day_first.data,
204203
iterator=True,
205204
keep_default_na=not form.null_values.data,
@@ -214,6 +213,7 @@ def form_post(self, form: CsvToDatabaseForm) -> Response:
214213
**kwargs,
215214
)
216215
)
216+
print(df)
217217

218218
database = (
219219
db.session.query(models.Database)

0 commit comments

Comments
 (0)