Timeseries Table does not update on dashboard when filters are changed

[michellethomas]

After the refactor of timeseries table, we've seen issues on dashboard where the data in the chart does not update when someone changes a dashboard filter. The chart seems to load, it says that the data is cached, but the actual numbers in the chart don't update.

I didn't look through the whole PR but I noticed that memoization was added here which seems like it could be the source of the issue.

I may put up a revert PR for this as it causes data quality issues, but let me know if I missed a fix for this or if someone is able to fix it soon.

@kgabryje @rusackas

Expected results

Data should update in timeseries table when filter is changed.

Actual results

Data does not consistently update in timeseries table when filter is changed.

How to reproduce the bug

1. Add a time series table and filter to dashboard
2. Change the filter and check if data has updated

Environment

(please complete the following information):

• superset version: master

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.93. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.