Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to change currency format from dollars to euros #11328

Closed
zsellami opened this issue Oct 19, 2020 · 9 comments
Closed

Enable to change currency format from dollars to euros #11328

zsellami opened this issue Oct 19, 2020 · 9 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community good first issue Good first issues for new contributors .pinned Draws attention

Comments

@zsellami
Copy link
Contributor

Hello,
I want to show euros values on dashboard. But only the $ format are enable. When i changed the $ symbol to € i obtained an error.
How can I show euros value in a chart ?

I want something like "y_axis_format": "$,.2f" ==> to "y_axis_format": ",.2f€"

Regards,
Zied Sellami

@issue-label-bot issue-label-bot bot added the enhancement:request Enhancement request submitted by anyone from the community label Oct 19, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.55. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@junlincc junlincc added good first issue Good first issues for new contributors .pinned Draws attention labels Oct 20, 2020
@junlincc
Copy link
Member

Thank you, Zied for suggesting the enhancement. This feature is not currently on Superset 1.0 roadmap so we won't be able to get to it till early next year likely. However, this looks like a 'good first issue' for any community contributors to work on. If you are interested in contributing, I can point you to the right direction and connect you with you engineers.

@dstadz
Copy link

dstadz commented Oct 22, 2020

Hey @junlincc, I am interested in contributing to this issue. Is it still available to be worked on?

@willbarrett
Copy link
Member

Yup, go ahead and work on it!

@leocape
Copy link
Contributor

leocape commented Nov 6, 2020

Also with specifying a currency it would be nice to have the option to remove decimals eg. $,.2f becomes $,.0f

@carlosaccp
Copy link

Is this issue still open? I would like to help!

@sahilkamboj3
Copy link

Is the issue still open? I would love to join and help out

@nytai
Copy link
Member

nytai commented Dec 20, 2020

@sahilkamboj3 I believe it is. If you open a PR, I can ensure it gets reviewed.

@junlincc
Copy link
Member

@carlosaccp, @sahilkamboj3 @dstadz sorry I missed your comments!! If you all are still interested in contributing, feel free to reach out to me in Slack. you will need to add this y-axis format to multiple viz plug-ins. We can help you navigate if needed. thanks!

@apache apache locked and limited conversation to collaborators Feb 2, 2022
@geido geido converted this issue into discussion #18408 Feb 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement:request Enhancement request submitted by anyone from the community good first issue Good first issues for new contributors .pinned Draws attention
Projects
None yet
Development

No branches or pull requests

8 participants