Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifting cursor (forward) when editing Markdown with emoji #11331

Closed
2 of 3 tasks
zuzana-vej opened this issue Oct 19, 2020 · 6 comments
Closed
2 of 3 tasks

Shifting cursor (forward) when editing Markdown with emoji #11331

zuzana-vej opened this issue Oct 19, 2020 · 6 comments
Assignees
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@zuzana-vej
Copy link
Contributor

When editing a markdown component with a specific emoji (which occupies two characters) - for example the start emoji which is by default on the markdown component, clicking on text places the cursor one character to the right and making editing confusing.

Expected results

Cursor stays at correct position

Actual results

Cursor jumps 1 step forward

Screenshots

It's hard without video, but here are few screenshots (I can share video if needed). In this example I am trying to correct "payouss" to "payouts"

Screen Shot 2020-10-19 at 10 16 07 AM

Screen Shot 2020-10-19 at 10 16 25 AM

Screen Shot 2020-10-19 at 10 17 00 AM

How to reproduce the bug

  1. Go to Dashboard, Add Markdown with emoji (e.g. the start shape)
  2. Try to edit a sentences (after the emoji) and see the cursor jumps around (deletes character forward, not correct one)

Environment

  • superset version: master

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@zuzana-vej zuzana-vej added the !deprecated-label:bug Deprecated label - Use #bug instead label Oct 19, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.69. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@zuzana-vej
Copy link
Contributor Author

@junlincc FYI. I know there are other two open bugs for markdown #11304 and #11257 they are all different, just wanted to surface this as it relates to the same component.

@junlincc junlincc self-assigned this Oct 20, 2020
@junlincc
Copy link
Member

@zuzana-vej Thank you, Zuzana for reporting and linking. We will get to it in a couple weeks 🙏

@junlincc
Copy link
Member

@kkucharc 🙏

@kkucharc
Copy link
Contributor

kkucharc commented Oct 28, 2020

I think this is known issue of Ace Editor.
Even it appears when I try put ✨ in their demo:
https://ace.c9.io/
I tried check the newest version of react-ace but it didn't help. I suggest to wait for a fix in the library.

@zuzana-vej
Copy link
Contributor Author

Thanks @kkucharc, closing this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

4 participants