Edit dashboard metadata now throws Dashboard collision warning on save

[zuzana-vej]

Currently after the recent fix to editing dashboard metadata and feature to prevent dashboard edit colisions, when you edit dashboard properties, even though the edits get saved, on the 2nd save on dashboard, user gets warning that "dashboard has been changed, please reload the page". Upon reloading the page, the changes are actually propagated, but this warning is confusing to the user.

I know there are some plans to refactor the save flows on dashboards, so raising this bug so that it can be addressed at that time.

Expected results

Do not show the warning when dashboard has been edited by the same user.

Actual results

Warning about "dashboard has been edited, please reload" pops up.

Screenshots

1. Edit dashboard metadata, Click save on Modal

2. Click save on dashboard

How to reproduce the bug

1. Go to Dashboard
2. Click on Edit, Edit Dashboard properties
3. Edit some metadata - it can be changing color scheme, or editing directly specific color in the Json
4. Save on Modal - all OK
5. Save on Dashboard - the warning wrongly displays.

Environment

• superset version: master

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Related past discussions:
#10655
#10834

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.75. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[junlincc]

@graceguo-supercat

we should definitely revisit the saving flow early next year! I added this item to Superset past 1.0 roadmap. https://github.com/apache-superset/superset-roadmap/projects/1

[eschutho]

I believe this issue was fixed in #10834. I wasn't able to replicate with current master, but can someone else verify?

[mistercrunch]

I hit this issue recently too editing the title of the dashboard I believe. We should make sure that all actions except for the master SAVE only affect the local redux state, and that the save button be the only action that syncs to the backend.

[zuzana-vej]

Looks like @graceguo-supercat PR fixed this issue, thanks! (the dashboard doesn't automatically refresh though, but that's separate issue, I think that's been there before as well, from a while back).