Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] prevent co-edit error in Dashboard Properties Modal #11633

Closed
graceguo-supercat opened this issue Nov 10, 2020 · 1 comment
Closed
Labels
enhancement:request Enhancement request submitted by anyone from the community

Comments

@graceguo-supercat
Copy link

graceguo-supercat commented Nov 10, 2020

Is your feature request related to a problem? Please describe.
There are a few PRs (and bug fixes) to prevent users edit the same dashboard at the same time: #11220 #11305 and #11614. Right now this feature is kind of stable, but it is not available when user update dashboard metadata in Dashboard Properties modal. Because /dashboard/api/v1 does not check dashboard version in update requests.

Describe the solution you'd like
Is possible that /dashboard/api/v1 PUT request also support dashboard version check, and return last_updated_time in response?

Additional context
maybe @dpgaspar can help?
cc @mistercrunch @eschutho @junlincc

@graceguo-supercat graceguo-supercat added the enhancement:request Enhancement request submitted by anyone from the community label Nov 10, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.84. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@apache apache locked and limited conversation to collaborators Feb 2, 2022
@geido geido converted this issue into discussion #18418 Feb 2, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Development

No branches or pull requests

1 participant